Skip to content

Lazily register for Core's firebaseUserAgent #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ryanwilson opened this issue May 22, 2018 · 0 comments · Fixed by #4441
Closed

Lazily register for Core's firebaseUserAgent #1306

ryanwilson opened this issue May 22, 2018 · 0 comments · Fixed by #4441
Assignees
@paulb777
Labels
api: core

Comments

@ryanwilson
Copy link
Member

Currently we register in FIROptions under +initialize (changed from +load in #1305).

firebase-ios-sdk/Firebase/Core/FIROptions.m

Line 118 in 11933c0

registerLibrary:@"fire-ios"

This could be optimized to lazily register in a dispatch_once block once firebaseUserAgent is called.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@paulb777 paulb777

Labels
api: core
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Lazily register for Core's user agent firebase/firebase-ios-sdk
3 participants
@paulb777 @ryanwilson @maksymmalyhin