Mac OS FIS: use Firebase App ID as a suffix to Keychain service name Mac OS #5603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulb777
approved these changes
May 13, 2020
FirebaseInstallations/Source/Library/InstallationsIDController/FIRInstallationsIDController.m
Outdated
Show resolved
Hide resolved
andirayo
reviewed
May 14, 2020
FirebaseInstallations/Source/Library/InstallationsIDController/FIRInstallationsIDController.m
Outdated
Show resolved
Hide resolved
FirebaseInstallations/Source/Library/InstallationsIDController/FIRInstallationsIDController.m
Show resolved
Hide resolved
FirebaseInstallations/Source/Library/InstallationsIDController/FIRInstallationsIDController.m
Show resolved
Hide resolved
andirayo
approved these changes
May 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses an issue detected during investigation of #5540.
GoogleServices-Info.plistas a suffix for Keychain Service name on Mac OS to make it unique per Mac OS app (see comments for details).NOTE: This change will lead to reset of Firebase Installation ID on Mac OS. Migration is not provided because for it we will have to access the old storage which will trigger the user alert described in #5540.
The Identifiers on iOS/TVOS/WatchOS won't be affected.