-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Use preserve_paths instead of CocoaPods private #5758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generated by 🚫 Danger |
510bd08
to
fb95b88
Compare
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor request - it may be helpful for future readers to have a comment at the top of this file specifying why it exists and why it's necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will add in #5760
I run into this error FirebaseCore/Sources/Private/FirebaseCoreInternal.h not find Flutter project |
Standardize and simplify internal FirebaseCore imports. Note the fast-follow #5760 changes the
preserve_path
tosource_files
so that the headers show up in generated Xcode projects.FirebaseCore/Sources/Private/FirebaseCoreInternal.h
instead of any specific header files.__has_include
test so old IID used by FIS tests can find the Core private headers since the old podspec doesn't know how to find repo-relative headers. Also necessary for the latest Core to work with other old Firebase 6.x pods.FIRErrorCodeConfigFailed
#if __cplusplus
for public header imports from the Core Firebase-internal headers since Objective C++ modules don't work for unqualified public header names. I changed this back to a#if SWIFT_PACKAGE
check in Migrate from interop pods to source_files header access #5760 since other issues came up with public header references from private headers there - so this can mostly be disregarded.The first commit is large, but purely the mechanical change of all of the import changes (from a small Swift script). The interesting changes are in the commits that follow.
I tested with the
private_headers
removed from the FirebaseCore podspec. I'm restored the private_headers before merging to avoid a breaking change before 7.0.