Sign in alert shown inconsistently when triggered in viewDidAppear

[lfkellogg]

[REQUIRED] Step 1: Describe your environment

• Xcode version: 12.4
• Firebase SDK version: 8.0.0
• Installation method: CocoaPods
• Firebase Component: App Distribution
• iOS version: 13+

[REQUIRED] Step 2: Describe the problem

Steps to reproduce:

1. Create a new Project, choose the "App" template, then set Interface to Storyboard
2. Follow the docs to set up the SDK in the "Basic" configuration, calling checkForUpdate from viewDidAppear
3. Run the app on a device running iOS 13+
4. [Optional] If the "Enable new build alerts" alert is shown on launch, kill the app from the app switcher and re-launch it

Expected behavior: on first launch and on subsequent launches before signing in, the SDK should show the "Enable new build alerts" alert.

Actual behavior: It is inconsistent. Often the alert will show up on first launch, but not on subsequent launches. Sometimes not even on first launch.

Relevant Code:

Debugging the SDK locally, the issue appears to be with this line:

firebase-ios-sdk/FirebaseAppDistribution/Sources/FIRAppDistributionUIService.m

Line 208 in f920f2f

if (connectedScene.activationState == UISceneActivationStateForegroundActive) {

Sometimes, the scene has not become active by the time viewDidAppear is called. In that case we do not find a foreground scene here, and the alert cannot be shown. This is illustrated by a workaround where checkForUpdate is triggered from the SceneDelegate's sceneDidBecomeActive instead.

[google-oss-bot]

I found a few problems with this issue:

• I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
• This issue does not seem to follow the issue template. Make sure you provide all the required information.

[tejasd]

This has been fixed for single scene apps in Firebase SDK version: 10.1.0