Skip to content

Improve error logging when table creation fails #8699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 25, 2022
Merged

Improve error logging when table creation fails #8699

merged 5 commits into from
Jan 25, 2022

Conversation

morganchen12
Copy link
Contributor

SQLite's documentation implies that sqlite3_exec is not guaranteed to return a non-null error message for every failure.

Improves error reporting for #8684, though it does not fix the crash.

@google-cla google-cla bot added the cla: yes label Sep 23, 2021
@google-oss-bot
Copy link

google-oss-bot commented Sep 24, 2021 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseMessaging-iOS-FirebaseMessaging.framework

    Overall coverage changed from 63.54% (52890bf) to 63.53% (f0dbce3) by -0.01%.

    FilenameBase (52890bf)Merge (f0dbce3)Diff
    FIRMessagingRmqManager.m57.00%57.00%+0.00%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/isCCC3HJ3w.html

@google-oss-bot
Copy link

google-oss-bot commented Sep 24, 2021 •
edited
Loading

Size Report 1

Affected Products

  • FirebaseMessaging

    TypeBase (52890bf)Merge (f0dbce3)Diff
    CocoaPods728 kB728 kB+56 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/9sDlxJZPXO.html

charlotteliang
charlotteliang approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@charlotteliang charlotteliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I just saw this.

@morganchen12 morganchen12 merged commit c506d39 into master Jan 25, 2022
@morganchen12 morganchen12 deleted the mc/fcm branch January 25, 2022 21:19
dennycd pushed a commit to dennycd/firebase-ios-sdk that referenced this pull request Jan 26, 2022
@morganchen12
Improve error logging when table creation fails (firebase#8699)
8beca56 
* Improve error logging when table creation fails

* add changelog

* style
leotianlizhan pushed a commit that referenced this pull request Feb 1, 2022
@morganchen12 @leotianlizhan
Improve error logging when table creation fails (#8699)
1b696b1 
* Improve error logging when table creation fails

* add changelog

* style
leotianlizhan pushed a commit that referenced this pull request Feb 1, 2022
@morganchen12 @leotianlizhan
Improve error logging when table creation fails (#8699)
fee4ff1 
* Improve error logging when table creation fails

* add changelog

* style
@firebase firebase locked and limited conversation to collaborators Feb 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@charlotteliang charlotteliang charlotteliang approved these changes

Assignees

@morganchen12 morganchen12

Labels
api: messaging cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@morganchen12 @google-oss-bot @charlotteliang