Crashlytics GDT fill in Exception part of Proto #4894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonhu-g
reviewed
Feb 12, 2020
| @@ -26,6 +26,8 @@ | |||
| #import <nanopb/pb_decode.h> | |||
| #import <nanopb/pb_encode.h> | |||
|
|
|||
| const NSUInteger IMPORTANCE_FOR_EXCEPTION = 0; | |||
There was a problem hiding this comment.
The naming for this may be confusing since the importance for exceptions be non-zero. Take a look at Protobuf.scala:384.
Maybe this should be DEFAULT_IMPORTANCE_FOR_EXCEPTION?
jasonhu-g
reviewed
Feb 12, 2020
| @@ -26,6 +26,8 @@ | |||
| #import <nanopb/pb_decode.h> | |||
| #import <nanopb/pb_encode.h> | |||
|
|
|||
| const NSUInteger IMPORTANCE_FOR_EXCEPTION = 0; | |||
There was a problem hiding this comment.
In FIRCLSRecordThread.m:21, we define IMPORTANCE_IN_CRASHED_THREAD. Does it make more sense to have this const be defined FIRCLSRecordFrame? FIRCLSRecordFrame could also expose an importance property to abstract the logic from this adapter class.
There was a problem hiding this comment.
Yeah that probably makes more sense to organize it all there
jasonhu-g
approved these changes
Feb 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exceptionpart of the app execution.signalProtoDoes not fill in symbolicated files or importance for symbolicated.