Skip to content

Checking the pasteboard for dynamic links in ios14 #5905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 29, 2020
Merged

Checking the pasteboard for dynamic links in ios14 #5905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8d01d06
Checking the first pasteboard item in ios14
ncooke3 Jun 24, 2020
2ed8aae
Cleaned up method and added ifdef
ncooke3 Jun 24, 2020
e3261d8
Renamed variable
ncooke3 Jun 24, 2020
b6f3b24
Style
ncooke3 Jun 24, 2020
16fb5e2
Refactored method
ncooke3 Jun 24, 2020
c954b2f
Using another url detecting api
ncooke3 Jun 26, 2020
250a76d
Made sure pasteboardContents is initialized
ncooke3 Jun 26, 2020
6c9ab4a
Changelog
ncooke3 Jun 29, 2020
f6e1f57
Merge branch 'master' into nc-dl-ios14
ncooke3 Jun 29, 2020
5d200fb
Update Changelog
ncooke3 Jun 29, 2020
b18a096
Removed trailing space
ncooke3 Jun 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions FirebaseDynamicLinks/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# Unversioned
- [fixed] Reduce frequency of iOS14 pasteboard notifications by only reading from it when it contains URL(s). (#5905)

# v4.3.0
- [changed] Functionally neutral updated import references for dependencies. (#5824)

Expand Down
14 changes: 13 additions & 1 deletion FirebaseDynamicLinks/Sources/FIRDLDefaultRetrievalProcessV2.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ - (void)markCompleted {

- (nullable NSURL *)uniqueMatchLinkToCheck {
_clipboardContentAtMatchProcessStart = nil;
NSString *pasteboardContents = [UIPasteboard generalPasteboard].string;
NSString *pasteboardContents = [self retrievePasteboardContents];
NSInteger linkStringMinimumLength =
expectedCopiedLinkStringSuffix.length + /* ? or & */ 1 + /* http:// */ 7;
if ((pasteboardContents.length >= linkStringMinimumLength) &&
Expand All @@ -296,6 +296,18 @@ - (nullable NSURL *)uniqueMatchLinkToCheck {
return nil;
}

- (NSString *)retrievePasteboardContents {
NSString *pasteboardContents = @"";
if (@available(iOS 10.0, *)) {
if ([[UIPasteboard generalPasteboard] hasURLs]) {
pasteboardContents = [UIPasteboard generalPasteboard].string;
}
} else {
pasteboardContents = [UIPasteboard generalPasteboard].string;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line alone will trigger the notification to be displayed!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the line 306 will be executed only on iOS < 10 therefore no popup.

Still the line 303 will trigger a popup, but I guess the point was to just "reduce" the popups (check the Changelog

}
return pasteboardContents;
}

- (void)clearUsedUniqueMatchLinkToCheckFromClipboard {
// See discussion in b/65304652
// We will clear clipboard after we used the unique match link from the clipboard
Expand Down