Skip to content

Remove FIRCLSURLSession #6212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 17, 2020
Merged

Remove FIRCLSURLSession #6212

merged 6 commits into from
Aug 17, 2020

Conversation

morganchen12
Copy link
Contributor

Removes unused pre-iOS 8 networking code in favor of NSURLSession. Fixes #6210.

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great to delete so much code! LGTM

Deferring approval to @samedson

@samedson
Copy link
Contributor

samedson commented Aug 5, 2020

Cool if I take a look Monday? Gonna be out tomorrow and Friday and I wanna do some testing on this

@morganchen12
Copy link
Contributor Author

@samedson yeah, Monday's plenty of time to make M78 code freeze. Enjoy your vacation!

@morganchen12
Copy link
Contributor Author

@samedson code freeze is tomorrow--let me know if we should punt this change

Copy link
Contributor

@samedson samedson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay! Just did validation on this for mac + tvOS too. LGTM!

@morganchen12 morganchen12 merged commit 22e8912 into master Aug 17, 2020
@morganchen12 morganchen12 deleted the morganchen/crash2 branch August 17, 2020 21:26
@firebase firebase locked and limited conversation to collaborators Sep 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong object type on FIRCLSURLSessionConfiguration creation
5 participants