-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Cache Functions instances by app #8258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the incremental coverage checker correct with its four reports? cc: @granluo
Functions/FirebaseFunctions/Public/FirebaseFunctions/FIRFunctions.h
Outdated
Show resolved
Hide resolved
Functions/FirebaseFunctions/Public/FirebaseFunctions/FIRFunctions.h
Outdated
Show resolved
Hide resolved
Talked to Ryan offline and we agreed it'd be best to move Functions to broader FIRComponent adoption, with these specific points:
It's a bit late for code freeze, but we can punt to M99 if necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on green
Fixes #7783.