Skip to content

Revert "Adding a new API that allows iOS users to log notification delivery signal that exports to BigQuery." #8458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 29, 2021
Merged

Revert "Adding a new API that allows iOS users to log notification delivery signal that exports to BigQuery." #8458

merged 3 commits into from
Jul 29, 2021

Conversation

maksymmalyhin
Copy link
Contributor

@maksymmalyhin maksymmalyhin commented Jul 29, 2021 •
edited
Loading

Reverts #8443, #8440, #6181

Reverting to give more time for investigation of #8448.

@maksymmalyhin maksymmalyhin changed the title Revert "Prevent firelog from logging invalid data" Revert "Adding a new API that allows iOS users to log notification delivery signal that exports to BigQuery." Jul 29, 2021
@maksymmalyhin maksymmalyhin marked this pull request as ready for review July 29, 2021 20:48
@google-cla google-cla bot added the cla: yes label Jul 29, 2021
@charlotteliang charlotteliang self-requested a review July 29, 2021 20:52
@google-oss-bot
Copy link

google-oss-bot commented Jul 29, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • FirebaseMessaging-iOS-FirebaseMessaging.framework

    SDK overall coverage changed from 64.60% (1cb3f70) to 64.25% (4ed42c1) by -0.35%.

    Filename Base (1cb3f70) Head (4ed42c1) Diff
    FIRMessagingContextManagerService.m 66.99% 66.83% -0.16%
    FIRMessagingExtensionHelper.m 83.47% 82.68% -0.79%

Test Logs

@maksymmalyhin
Copy link
Contributor Author

SPM checks fails where introduced in #8456 and are not relevant to the PR. pod spec lint fails because the podspec uses an existing version with existing tag pointing to incompatible code.
I'm merging the PR.

@maksymmalyhin maksymmalyhin merged commit b8e974d into master Jul 29, 2021
@maksymmalyhin maksymmalyhin deleted the revert-8443-chen-spm-test branch July 29, 2021 21:47
charlotteliang added a commit that referenced this pull request Jul 29, 2021
@charlotteliang
Revert "Revert "Adding a new API that allows iOS users to log notific…
5abe702 
…ation delivery signal that exports to BigQuery." (#8458)"

This reverts commit b8e974d.
@charlotteliang charlotteliang mentioned this pull request Jul 29, 2021
Merged
@firebase firebase locked and limited conversation to collaborators Aug 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@charlotteliang charlotteliang charlotteliang approved these changes

Assignees
No one assigned
Labels
api: messaging cla: yes public-api-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maksymmalyhin @google-oss-bot @charlotteliang