Skip to content

Create a random delay before initiating a remote config fetch. #8593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 1, 2021
Merged

Create a random delay before initiating a remote config fetch. #8593

merged 6 commits into from
Sep 1, 2021

Conversation

visumickey
Copy link
Contributor

@visumickey visumickey commented Aug 30, 2021 •
edited
Loading

Rationale:
This is required to ensure that a remote notification does not trigger multiple config fetches from remote config at the same time. Internal bug reference: b/187985523

@visumickey
Create a random delay before initiating a remote config fetch.
245ad9f 
This is required to ensure that a remote notification does not trigger multiple config fetches from remote config at the same time.
@google-cla google-cla bot added the cla: yes label Aug 30, 2021
paulb777
paulb777 reviewed Aug 31, 2021
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix CI

jeremyjiang-dev
jeremyjiang-dev reviewed Aug 31, 2021
View reviewed changes
jeremyjiang-dev
jeremyjiang-dev approved these changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@jeremyjiang-dev jeremyjiang-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on CI green

@google-oss-bot
Copy link

google-oss-bot commented Sep 1, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • FirebasePerformance-iOS-FirebasePerformance.framework

    SDK overall coverage changed from 92.34% (52ccaba) to 92.35% (6799fc1) by +0.01%.

    Filename Base (52ccaba) Head (6799fc1) Diff
    FPRRemoteConfigFlags.m 98.26% 98.32% +0.06%

Test Logs

@visumickey visumickey requested a review from karenyz September 1, 2021 23:32
@visumickey visumickey merged commit 95830b2 into master Sep 1, 2021
@visumickey visumickey deleted the perf_addRandomRCDelay branch September 1, 2021 23:46
@leotianlizhan leotianlizhan mentioned this pull request Sep 10, 2021
Merged
@firebase firebase locked and limited conversation to collaborators Oct 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@karenyz karenyz Awaiting requested review from karenyz

+1 more reviewer

@jeremyjiang-dev jeremyjiang-dev jeremyjiang-dev approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: performance cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@visumickey @google-oss-bot @paulb777 @jeremyjiang-dev