Skip to content

Fix for issue #8907 InApp message is shown every new session #8922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 3, 2021

Conversation

alien190
Copy link
Contributor

@alien190 alien190 commented Nov 3, 2021

Fix for issue #8907 InApp message is shown every new session (timestamp of the impression record is always 0 seconds).

…(timestamp of the impression record is always 0 seconds).
@google-cla
Copy link

google-cla bot commented Nov 3, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Nov 3, 2021
@alien190
Copy link
Contributor Author

alien190 commented Nov 3, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Nov 3, 2021
@paulb777 paulb777 added the api: inappmessaging Firebase In App Messaging label Nov 3, 2021
@paulb777
Copy link
Member

paulb777 commented Nov 3, 2021

@alien190 Thanks for the PR! @eldhosembabu PTAL

@eldhosembabu
Copy link
Contributor

LGTM

@eldhosembabu eldhosembabu requested review from eldhosembabu and removed request for eldhosembabu December 3, 2021 20:53
@eldhosembabu eldhosembabu merged commit 5653583 into firebase:master Dec 3, 2021
@firebase firebase locked and limited conversation to collaborators Jan 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: inappmessaging Firebase In App Messaging cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants