#286: Emulator UI should not connect to 0.0.0.0 for emulators

[gautamsingal]

Description:
- Added check whether info.host is not 0.0.0.0 or ::
- If it is present, then update the host with localhost else it remains same
- Pass the new value to hostAndPort

[yuchenshi]

Thanks for the contribution! This looks good, but one small nit: please use 127.0.0.1 for IPv4 and ::1 for IPv6 instead of localhost.

The reason is that localhost may be mapped to both on the hosts file and may differ on each device. IP addresses are more direct and uniformly handled.

[gautamsingal]

@yuchenshi Will this be good?
const host = info.host === '0.0.0.0' || info.host === '::' ? info.host === '0.0.0.0' ? '127.0.0.1' : '::1' : info.host;

[yuchenshi]

const host = info.host === '0.0.0.0' || info.host === '::' ? info.host === '0.0.0.0' ? '127.0.0.1' : '::1' : info.host;

That is logically correct, but for let's stay away from chained ternaries for clarity. I suggest:

let host = info.host;
if (host === '0.0.0.0') {
  host = '127.0.0.1';
} else if (host === '::') {
  host = '::1';
}

[gautamsingal]

@yuchenshi Okay 😁

[yuchenshi]

This will be included in the next release. Cheers!

[gautamsingal]

Great! Thanks @yuchenshi . Cheers!