-
Notifications
You must be signed in to change notification settings - Fork 1k
Add root: true to eslintrc #2925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Set `root: true` in the .eslintrc template, so that ESLint doesn't try to combine the configuration in the `functions` directory with the configuration in an `.eslintrc` file in the parent app directory.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
Sorry for being super delayed. I like this idea, but could you update this branch with master and then update both |
Taking the idea and running with it (keeping your initial commit) in #3029. Thanks! |
Set
root: true
in the .eslintrc template, so that ESLint doesn't try to combine the configuration in thefunctions
directory with the configuration in an.eslintrc
file in the parent app directory.