Skip to content

Use 'tsc' to compile JavaScript #2946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 6, 2021
Merged

Use 'tsc' to compile JavaScript #2946

merged 11 commits into from
Jan 6, 2021

Conversation

samtstern
Copy link
Contributor

@samtstern samtstern commented Dec 16, 2020

Description

This is an alternative way to fix #2944 and ensure we can never have a simple bug like that again. With these changes the test:compile step would have said:

 npm run test:compile

> [email protected] test:compile /Users/samstern/Projects/firebase-tools
> tsc --project tsconfig.compile.json

src/deploy/functions/release.js:20:7 - error TS2339: Property 'checkForNode8' does not exist on type 'typeof import("/Users/samstern/Projects/firebase-tools/src/deploy/functions/checkRuntimeDependencies")'.

20 var { checkForNode8 } = require("./checkRuntimeDependencies");
         ~~~~~~~~~~~~~


Found 1 error.

The only changes that scare me are the places I changed utils.reject to throw new FirebaseError in otherwise synchronous methods ... but I think that is correct?

Scenarios Tested

None?

Sample Commands

N/A

@google-cla google-cla bot added the cla: yes Manual indication that this has passed CLA. label Dec 16, 2020
@samtstern samtstern requested a review from bkendall December 16, 2020 17:45
@samtstern
Copy link
Contributor Author

@bkendall assigning you to give a high-level take on the idea.

@samtstern samtstern merged commit e427b78 into master Jan 6, 2021
@bkendall bkendall deleted the ss-compile-js branch August 4, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

checkForNode8 is not a function
2 participants