Skip to content

feat(auth): update Pigeon version to 19 #12828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 28, 2024
Merged

feat(auth): update Pigeon version to 19 #12828

merged 10 commits into from
May 28, 2024

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented May 24, 2024

Description

Aligning all constraints to Web constraints. As discussed before, it was already the case with the previous version but not reflected in the front facing package.

Also updated the Flutter SDK constraints, (Dart 3.2 meant Flutter 3.16 already)

  • (iOS) Booleans were held in a NSNumber which is not the case anymore (nice but annoying since no linting errors)
  • EventChannels decoding system has changed
  • Lot of signature/naming changed

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Lyokone Lyokone force-pushed the feat/pigeon19auth branch 5 times, most recently from fc0fca4 to 71bf3b3 Compare May 24, 2024 13:06
@Lyokone Lyokone force-pushed the feat/pigeon19auth branch from ae77c01 to 71d244c Compare May 27, 2024 09:18
@Lyokone Lyokone merged commit 5e76153 into master May 28, 2024
23 of 24 checks passed
@Lyokone Lyokone deleted the feat/pigeon19auth branch May 28, 2024 08:24
@firebase firebase locked and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants