Skip to content

fix(storage, web): clean up stream handlers on "hot restart" #12927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Jun 7, 2024

Description

  1. This commit fixed an issue where stream was being recreated again (on task.pause() it was calling snapshotEvents again). Also fixed task.pause() so it paused when paused state came through. Also throwing exception.
  2. Usual clean up on "hot restart" of stream handlers.

Related Issues

closes: #7064

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Lyokone Lyokone merged commit 0ea7099 into master Jun 11, 2024
26 checks passed
@Lyokone Lyokone deleted the storage-7064 branch June 11, 2024 06:42
@firebase firebase locked and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants