Skip to content

fix(firebase_auth): added supporting rawNonce for OAuth credential on Windows platform #13086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

JekaNS
Copy link
Contributor

@JekaNS JekaNS commented Jul 20, 2024

Description

Added support for the rawNonce field in credential builder on the Windows platform.

Since there is no implementation of AppleAuthProvider on Windows platform, I am trying to use OAuthProvider. This works on MacOS, but on Windows I couldn't pass an idToken with a rawNonce and no accessToken to the credential builder. And signInWithCredentials threw an exception.

With this PR if rawNonce is provided then will be used overloaded credential builder firebase::auth::OAuthProvider::GetCredential that accept rawNonce argument.

Example of use:

    final credential = OAuthProvider("apple.com").credential(idToken: webAuthRes.idToken, rawNonce: webAuthRes.nonce);
    FirebaseAuth.instance.signInWithCredential(credential);

Related Issues

No existing issues found ((

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Lyokone
Copy link
Contributor

Lyokone commented Jul 26, 2024

Hello @JekaNS thanks a lot for this feature, it looks great. I'll do a couple of manual tests first but it should be fine

@Lyokone
Copy link
Contributor

Lyokone commented Jul 26, 2024

Can you just check the formatting of the files?

@JekaNS
Copy link
Contributor Author

JekaNS commented Jul 26, 2024

Hi @Lyokone,
Sure. Formating fixed.

@Lyokone Lyokone merged commit 12e87de into firebase:master Jul 31, 2024
16 of 20 checks passed
@Lyokone
Copy link
Contributor

Lyokone commented Jul 31, 2024

Thanks for the contribution!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants