fix(crashlytics): read firebase_crashlytics_collection_enabled from AndroidManifest.xml #13217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyokone
reviewed
Aug 26, 2024
| // if so. | ||
| Logger.getLogger().e("Could not read data collection permission from manifest", e); | ||
| } | ||
| return null; |
There was a problem hiding this comment.
Should this default to false?
There was a problem hiding this comment.
I think it should default to true as stated in the docs.
There was a problem hiding this comment.
Oh yes to true sorry, then you can simplify
if (manifestEnabled != null) {
FirebaseCrashlytics.getInstance().setCrashlyticsCollectionEnabled(manifestEnabled);
enabled = manifestEnabled;
} else {
FirebaseCrashlytics.getInstance().setCrashlyticsCollectionEnabled(true);
enabled = true;
}
to only
FirebaseCrashlytics.getInstance().setCrashlyticsCollectionEnabled(manifestEnabled);
enabled = manifestEnabled;
There was a problem hiding this comment.
Right. That should work.
Lyokone
approved these changes
Aug 26, 2024
exaby73
reviewed
Aug 26, 2024
packages/firebase_crashlytics/firebase_crashlytics/example/ios/Flutter/AppFrameworkInfo.plist
Show resolved
Hide resolved
exaby73
approved these changes
Aug 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Crashylytics does not read
firebase_crashlytics_collection_enabledmeta data from AndroidManifest.xmlRelated Issues
Closes 13105
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?