Skip to content

feat(auth): support for linkDomain in ActionCodeSettings #17099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 18, 2025

Conversation

SelaseKay
Copy link
Contributor

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley changed the title feat(auth): add linkDomain support feat(auth): support for linkDomain in ActionCodeSettings Feb 17, 2025
@russellwheatley russellwheatley marked this pull request as ready for review February 18, 2025 09:58
@russellwheatley russellwheatley merged commit 090cdb2 into main Feb 18, 2025
28 of 29 checks passed
@russellwheatley russellwheatley deleted the auth-linkDomain branch February 18, 2025 11:23
@percula
Copy link

percula commented Feb 18, 2025

This causes an issue with macos, seems that the files were only updated in /ios and not /macos.

.pub-cache/hosted/pub.dev/firebase_auth-5.5.0/macos/firebase_auth/Sources/firebase_auth/PigeonParser.m:137:18: error: property 'linkDomain' not found on object of type 'FIRActionCodeSettings *'
137 | codeSettings.linkDomain = settings.linkDomain;

Edit: This is fixed by increasing the Firebase version in the Podfile

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants