-
Notifications
You must be signed in to change notification settings - Fork 4k
🐛 [firebase_dynamic_links] Enabling FlutterDeepLinkingEnabled
in Info.plist file, Firebase dynamic links are handled as deep-links by default on iOS and Android
#9469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for the detailed report @Ayman-Barghout From plugin's change log for version I tried the plugin's example on iOS, but didn't notice the behavior.
Can you try without it and see if you are still able to replicate the behavior ? If so, a minimal code sample would be good to analyze further. |
Thanks for your sincere reply @darshankawar I have always used I think I know why it is happening and it's not mainly because of <key>FlutterDeepLinkingEnabled</key>
<true/> When we remove the above So, I think some interaction between Flutter's deep-linking and Related SO post: https://stackoverflow.com/questions/73262332/flutter-ios-firebase-dynamic-link-push-named-page-with-the-link-value So the criteria for reproducing this issue:
Thanks a lot for your patience and help! |
Thanks for these details and analysis. Using steps to replicate above, I am seeing same behavior as reported, ie, the dynamic links are handled as deep links by default on iOS, when we enable Flutter deep-linking as mentioned above. /cc @russellwheatley |
FlutterDeepLinkingEnabled
in Info.plist file, Firebase dynamic links are handled as deep-links by default on iOS
Hello, thanks for the great work on FlutterFire packages, I don't mean to nag but this issue is keeping us away from using |
I've the same issue on android, this does not seem to be specific to ios. @darshankawar have you tried on android ? It is achieved by adding this to android manifest under
We are using this to return to the application after a succesful payment with the bank (3DS2) which redirects with a custom scheme in order to not have the native "open this link with chome or app" dialog. Removing deeplinking does not seem to be an option for us. |
I've just ran into this issue as well. It seems like the deep linking plugin (flutter_deeplinking_enabled=true) captures all links, including Dynamic Links, and triggers a Navigation with the URL's path. It does this with all hostnames. So, say I have I'm not sure how to workaround it or what the fix might be though. |
@blopker for us, we have to keep the version to a really old one |
That's fair. Our solution was to just not use Dynamic Links. The login page on our web app has some minimal routing logic to direct people to get the Android or iOS app. Also not ideal, but deeps links are more important than dynamic links for us right now. |
@blopker @Ayman-Barghout can anyone of you confirm this issue is also valid for android ? The title is misleading if that's the case. |
Yes, this is also valid for Android. |
@darshankawar Could you edit the title and labels to add platform android ? Sorry to bug everyone for that but I don't want this issue to be mislabeled and lose prioritization points as a result. |
FlutterDeepLinkingEnabled
in Info.plist file, Firebase dynamic links are handled as deep-links by default on iOSFlutterDeepLinkingEnabled
in Info.plist file, Firebase dynamic links are handled as deep-links by default on iOS and Android
I'm not sure how Firebase Dynamic Links is supposed to solve this problem. If you read Flutter's documentation here, it states:
We don't have input on how Flutter uses deep links, it is out of our control. @Ayman-Barghout could you elaborate what you mean by this?
I was under the impression Firebase iOS Dynamic Links has always used deep links? What was the alternative they were using? Again, not sure this would be something we could change on FlutterFire (assuming there has been a shift to deep links as you mentioned), this would be an implementation change on the Firebase iOS SDK which FlutterFire is a wrapper around. |
I think you got a solid point, everything does work as expected since dynamic links are set up as deep links, maybe what we needed was more control over which domains/URLs to navigate to and which to not, but that's something that is handled by Flutter. What we did is use |
Bug report
Starting from version
3.0.0
thefirebase_dynamic_links
plugin started to handle dynamic links as deep-links by default on iOS, I tried on version2.0.11
and it works normally but from version3.0.0
onward - till latest version4.3.6
this issue can be observed.Steps to reproduce
Steps to reproduce the behavior:
3.0.0
or above (current version also works).xcrun simctl openurl booted <dynamic_link>
commandonLink
andgetInitialLink
Expected behavior
The dynamic link should be only handled in the
firebase_dynamic_links
APIs (onLink
andgetInitialLink
) and not handled by the OS as a deep-link AFAIK.Sample project
I couldn't run the example project for
firebase_dynamic_links
but I guess it should be reproducible there, if not then please let me know so I can provide a really simple sample project.Additional context
I am using
go_router
in my project, I am not sure if that might cause this issue but I doubt it.Flutter doctor
Run
flutter doctor
and paste the output below:Click To Expand
Flutter dependencies
Run
flutter pub deps -- --style=compact
and paste the output below:Click To Expand
The text was updated successfully, but these errors were encountered: