Skip to content

analytics select_content should not have items #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 8, 2022
Merged

Conversation

andreaowu
Copy link
Contributor

There's an error in the Analytics docs here. The code snippet is for the select_content event, but in the Events documentation, select_content doesn't have items. This PR removes items.

@andreaowu andreaowu changed the title analytics select_content does not have items analytics select_content should not have items Aug 24, 2022
@thatfiredev
Copy link
Member

@andreaowu Seems like you undid your changes when you ran snippets

@andreaowu andreaowu requested a review from markarndt August 24, 2022 21:19
@andreaowu
Copy link
Contributor Author

@andreaowu Seems like you undid your changes when you ran snippets

Oops, thanks for catching that! Updated

@andreaowu andreaowu merged commit 7403e77 into master Sep 8, 2022
@andreaowu andreaowu deleted the analytics-doc-typo branch September 8, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants