Support static DevTools extensions #7612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 18, 2024
bkonyi
reviewed
Apr 18, 2024
packages/devtools_app/lib/src/extensions/extension_service.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/extensions/extension_service.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/extensions/extension_service.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/extensions/extension_service.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/extensions/extension_service.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/extensions/extension_service.dart
Outdated
Show resolved
Hide resolved
packages/devtools_shared/lib/src/extensions/extension_manager.dart
Outdated
Show resolved
Hide resolved
packages/devtools_shared/lib/src/extensions/extension_model.dart
Outdated
Show resolved
Hide resolved
|
Changes LGTM so far. Will re-review once tests are added. |
bkonyi
reviewed
Apr 23, 2024
packages/devtools_app/lib/src/extensions/extension_service.dart
Outdated
Show resolved
Hide resolved
packages/devtools_test/lib/src/mocks/generated_mocks_factories.dart
Outdated
Show resolved
Hide resolved
bkonyi
approved these changes
Apr 24, 2024
|
@DanTup would you be able to test this out on Windows and verify this is WAI?
|
|
Edit: Ignore that... it was taking a while to start up and I opened the log file.. but I had not enabled logging and was logging at an old log from last time I was using this test project 🤦♂️ |
|
Tested a few things discussed with Kenzie over chat, all looks good to me on Windows :-)
|
bkonyi
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #7569.
Still working on test coverage but this is ready for an initial review.