[flutter_tools] Migrate platforms away from .flutter-plugins #48918

franciscojma86 · 2020-01-15T22:11:20Z

#48614 moves the plugins list to .flutter-plugins-dependencies. .flutter-plugins will be kept for a whilee to avoid breaking existing apps, but should be removed after the migration is complete

The text was updated successfully, but these errors were encountered:

jmagman · 2020-01-18T02:28:18Z

Is this a duplicate of #39657?

jmagman · 2020-01-18T02:29:08Z

Oh never mind this is the cleanup step.

dnfield · 2020-12-08T19:14:24Z

Is the migration on this complete?

jmagman · 2020-12-08T20:09:48Z

It's still being parsed:

flutter/packages/flutter_tools/gradle/flutter.gradle

Line 375 in d9bf879

    
           File pluginsFile = new File(project.projectDir.parentFile.parentFile, '.flutter-plugins')

flutter/packages/flutter_tools/templates/cocoapods/Podfile-macos

Line 71 in d9bf879

plugin_pods = parse_KV_file('../.flutter-plugins')

flutter/packages/flutter_tools/lib/src/android/gradle.dart

Line 765 in d9bf879

final File flutterPluginFile = flutterProject.flutterPluginsFile;

flutter/packages/flutter_tools/lib/src/commands/packages.dart

Line 84 in 5ba2d79

    
           final int numberOfPlugins = (rootProject.flutterPluginsFile.readAsLinesSync()).length;

christopherfujino · 2023-08-01T20:20:31Z

Looks like we're still parsing this in 2023: https://github.com/flutter/flutter/blob/master/packages/flutter_tools/gradle/src/main/groovy/flutter.groovy#L543

Gustl22 · 2023-10-25T21:05:13Z

There may are projects, which were created with an old settings.gradle file, which references the .flutter-plugins file directly. This also may needs a test to not break the user experience somehow or write a proper migration / error message to upgrade it.
For reference:
#137115 (comment)
#98048 (comment)

Edit: it also states to remove dependencyGraph after migration, which is still used in flutter.groovy and I wonder how multiple transitive dependencies are handled then...or they just directly are stated in the plugins section then and the handling can just be safely removed (?)

Relands #97823 When the tool migrated to `.flutter-plugins-dependencies`, the Gradle plugin was never changed. Until now, the plugin had the heuristic that a plugin with a `android/build.gradle` file supported the Android platform. Also applies schema of `getPluginDependencies` to `getPluginList` which uses a `List` of Object instead of `Properties`. Fixes #97729 Cause of the error: https://github.com/flutter/flutter/blob/5f105a6ca7a5ac7b8bc9b241f4c2d86f4188cf5c/packages/flutter_tools/gradle/flutter.gradle#L421C25-L421C25 Fixes #98048 The deprecated line `include ":$name"` in `settings.gradle` (pluginEach) in old projects causes the `project.rootProject.findProject` to also find the plugin "project", so it is not failing on the `afterEvaluate` method. But the plugin shouldn't be included in the first place as it fails with `Could not find method implementation() for arguments` error in special cases. Related to #48918, see [_writeFlutterPluginsListLegacy](https://github.com/flutter/flutter/blob/27bc1cf61a5b54bf655062be63050123abb617e4/packages/flutter_tools/lib/src/flutter_plugins.dart#L248). Co-authored-by: Emmanuel Garcia <[email protected]>

Gustl22 · 2023-12-21T20:40:53Z

Looks like we're still parsing this in 2023

This is now solved in #137115

I think #54566 is obsolete due to #135392 and we can remove all the .flutter-plugins related stuff (generation and tests) after the deprecation period.

Relands flutter#97823 When the tool migrated to `.flutter-plugins-dependencies`, the Gradle plugin was never changed. Until now, the plugin had the heuristic that a plugin with a `android/build.gradle` file supported the Android platform. Also applies schema of `getPluginDependencies` to `getPluginList` which uses a `List` of Object instead of `Properties`. Fixes flutter#97729 Cause of the error: https://github.com/flutter/flutter/blob/5f105a6ca7a5ac7b8bc9b241f4c2d86f4188cf5c/packages/flutter_tools/gradle/flutter.gradle#L421C25-L421C25 Fixes flutter#98048 The deprecated line `include ":$name"` in `settings.gradle` (pluginEach) in old projects causes the `project.rootProject.findProject` to also find the plugin "project", so it is not failing on the `afterEvaluate` method. But the plugin shouldn't be included in the first place as it fails with `Could not find method implementation() for arguments` error in special cases. Related to flutter#48918, see [_writeFlutterPluginsListLegacy](https://github.com/flutter/flutter/blob/27bc1cf61a5b54bf655062be63050123abb617e4/packages/flutter_tools/lib/src/flutter_plugins.dart#L248). Co-authored-by: Emmanuel Garcia <[email protected]>

bartekpacia · 2024-01-09T17:34:07Z

@Gustl22 What's the deprecation period in this case? Will it start counting when the next Flutter stable is released and the imperative apply plugin way of applying Flutter's Gradle plugin becomes deprecated (as described in this migration guide)?

Gustl22 · 2024-01-09T23:28:58Z

@bartekpacia I'm not that familiar with the process. But it then has the same cycle as the imperative apply plugin deprecation. I think the counting starts when this is released to stable then.

) Code references: https://github.com/search?q=repo%3Aflutter%2Fflutter%20%22legacy_versions%22&type=code. Closes #87922. Work towards #48918.

…157388) Work towards #48918. This file was soft deprecated in _2020_, but the code was never removed. This warning message will serve as a warning and we'll rip out support for `flutter-plugins` after the _next_ stable release (i.e. after the mid-November branch cut).

Work towards flutter/flutter#48918. --------- Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>

…` file. (#157388)" (#157541) Reverts: #157388 Initiated by: matanlurey Reason for reverting: We have `--fatal-warnings` on postsubmit and this breaks the tree. Original PR Author: matanlurey Reviewed By: {reidbaker} This change reverts the following previous change: Work towards #48918. This file was soft deprecated in _2020_, but the code was never removed. This warning message will serve as a warning and we'll rip out support for `flutter-plugins` after the _next_ stable release (i.e. after the mid-November branch cut).

…r-plugins` file. (#157388)" (#157541)" (#157549) Reverts: #157541 Initiated by: matanlurey Reason for reverting: Was _not_ the cause of failure, see #157542. Original PR Author: auto-submit[bot] Reviewed By: {fluttergithubbot} This change reverts the following previous change: Reverts: #157388 Initiated by: matanlurey Reason for reverting: We have `--fatal-warnings` on postsubmit and this breaks the tree. Original PR Author: matanlurey Reviewed By: {reidbaker} This change reverts the following previous change: Work towards #48918. This file was soft deprecated in _2020_, but the code was never removed. This warning message will serve as a warning and we'll rip out support for `flutter-plugins` after the _next_ stable release (i.e. after the mid-November branch cut).

…t`. (#157527) Work towards #48918. Workaround for #157391 (see #157393 (comment)). I'll run all post-submit tasks as well on this PR using `test: all`.

…ter#157380) Code references: https://github.com/search?q=repo%3Aflutter%2Fflutter%20%22legacy_versions%22&type=code. Closes flutter#87922. Work towards flutter#48918.

…lutter#157388) Work towards flutter#48918. This file was soft deprecated in _2020_, but the code was never removed. This warning message will serve as a warning and we'll rip out support for `flutter-plugins` after the _next_ stable release (i.e. after the mid-November branch cut).

matanlurey · 2024-11-15T00:29:19Z

As of the latest master, this is true behind the flag flutter config explicit-package-dependencies.

matanlurey · 2025-02-22T02:19:22Z

As of the latest master (#160289), this is true by default.

After the next stable release, the ability to opt-out will be removed, and the feature can be removed.

dnfield added tool Affects the "flutter" command-line tool. See also t: labels. c: API break Backwards-incompatible API changes labels Jan 16, 2020

JCKodel mentioned this issue Apr 20, 2020

[flutter_tools] Conflict when editing project on Mac then on Windows (or vice-versa) #55231

Closed

This was referenced Dec 17, 2020

Move macOS Podfile logic into the tool #72020

Merged

Migrate usage value plugin count off .flutter-plugins #72538

Merged

flutter-triage-bot bot added the team-tool Owned by Flutter Tool team label Jul 8, 2023

christopherfujino mentioned this issue Jul 14, 2023

[flutter_tools] triage backlog issues #130635

Closed

christopherfujino added the P3 Issues that are less important to the Flutter project label Aug 1, 2023

christopherfujino added the triaged-tool Triaged by Flutter Tool team label Aug 1, 2023

This was referenced Oct 19, 2023

[Federated Plugins] Provide a way to override a default/endorsed platform implementation #80374

Closed

feat: Support overriding native endorsed plugins #137040

Merged

Reland: "Fix how Gradle resolves Android plugin" #137115

Merged

matanlurey added P2 Important issues not at the top of the work list and removed P3 Issues that are less important to the Flutter project labels Oct 22, 2024

matanlurey self-assigned this Oct 22, 2024

matanlurey mentioned this issue Oct 22, 2024

Remove the only reference to settings.gradle.legacy_versions. #157380

Merged

This was referenced Oct 22, 2024

Added a warning if flutter.groovy uses a .flutter-plugins file. #157388

Merged

Announce deprecation of .flutter-plugins. flutter/website#11303

Merged

Allow opting out of .flutter-plugins, opt-out in refreshPluginsList. #157527

Merged

matanlurey added a commit to flutter/website that referenced this issue Oct 24, 2024

Announce deprecation of .flutter-plugins. (#11303)

93fe19a

Work towards flutter/flutter#48918. --------- Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>

matanlurey mentioned this issue Oct 24, 2024

Use .flutter-plugin-dependencies to decide if plugins exist in a project. #157533

Closed

auto-submit bot mentioned this issue Oct 24, 2024

Reverts "Added a warning if flutter.groovy uses a .flutter-plugins file. (#157388)" #157541

Merged

auto-submit bot mentioned this issue Oct 24, 2024

Reverts "Reverts "Added a warning if flutter.groovy uses a .flutter-plugins file. (#157388)" (#157541)" #157549

Merged

matanlurey mentioned this issue Oct 26, 2024

Update settings.gradle for example apps to remove .flutter-plugins #157660

Closed

matanlurey added the p: waiting for stable update flutter/packages issues that can't be fixed until functionality reaches the stable Flutter channel label Feb 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[flutter_tools] Migrate platforms away from .flutter-plugins #48918

[flutter_tools] Migrate platforms away from .flutter-plugins #48918

franciscojma86 commented Jan 15, 2020

jmagman commented Jan 18, 2020

jmagman commented Jan 18, 2020

dnfield commented Dec 8, 2020

jmagman commented Dec 8, 2020

christopherfujino commented Aug 1, 2023

Gustl22 commented Oct 25, 2023 •

edited

Loading

Gustl22 commented Dec 21, 2023

bartekpacia commented Jan 9, 2024 •

edited

Loading

Gustl22 commented Jan 9, 2024 •

edited

Loading

matanlurey commented Nov 15, 2024

matanlurey commented Feb 22, 2025 •

edited

Loading

[flutter_tools] Migrate platforms away from .flutter-plugins #48918

[flutter_tools] Migrate platforms away from .flutter-plugins #48918

Comments

franciscojma86 commented Jan 15, 2020

jmagman commented Jan 18, 2020

jmagman commented Jan 18, 2020

dnfield commented Dec 8, 2020

jmagman commented Dec 8, 2020

christopherfujino commented Aug 1, 2023

Gustl22 commented Oct 25, 2023 • edited Loading

Gustl22 commented Dec 21, 2023

bartekpacia commented Jan 9, 2024 • edited Loading

Gustl22 commented Jan 9, 2024 • edited Loading

matanlurey commented Nov 15, 2024

matanlurey commented Feb 22, 2025 • edited Loading

Gustl22 commented Oct 25, 2023 •

edited

Loading

bartekpacia commented Jan 9, 2024 •

edited

Loading

Gustl22 commented Jan 9, 2024 •

edited

Loading

matanlurey commented Feb 22, 2025 •

edited

Loading