-
Notifications
You must be signed in to change notification settings - Fork 12.2k
compare llama-bench: add option to plot #14169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compare llama-bench: add option to plot #14169
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this would be useful for my work. For more general use consider also adding support for plotting the performance of only a single commit. Non-developer users are frequently more interested in determining the performance of their setup rather than the performance of the software so they would be I think more interested in running llama-bench for only a single commit and plotting the performance of that. In practical terms the interface change that I envision would be to make --compare
optional. The opposite case where you may want to compare more than two commits could also be interesting. (These things should be in separate PRs.)
Regarding capitalization: I'm going by the standards that are common in my line of work unrelated to llama.cpp (high energy physics) where the guideline is not to capitalize every word in plot titles and axis names. Because the |
Just FYI, I haven't forgotten about adding Mermaid support, but I was working on comparing across columns first (ie, comparing two different models or options) and got stuck in SQL hell so it got stashed and put on the back burner. :( |
Sorry, but I'm not going to turn down this PR when it does what I need with the tools that I'm used to. |
Oh, no, I wasn't suggesting that, this PR looks great! |
10042de
to
567b2cb
Compare
567b2cb
to
deeaecf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there's nothing else from your side I'll merge.
Creates graph with varying one variable (default:
n_depth
) and keeping others constant, added--plot
(for plot location) and--plot_x
(for x-axis) in the scriptexample graph
