Skip to content

gguf-py : fix Qwen3-Embedding eos token #14314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 21, 2025
Merged

Conversation

CISC
Copy link
Collaborator

@CISC CISC commented Jun 21, 2025

Qwen3-Embedding sets a different EOS token than defined in tokenizer_config.json using TemplateProcessing, so we override that if detected (and try to shift EOS onto EOT/EOM just in case).

@CISC CISC requested a review from compilade June 21, 2025 06:18
@CISC CISC linked an issue Jun 21, 2025 that may be closed by this pull request
4 tasks
@github-actions github-actions bot added the python python script changes label Jun 21, 2025
@CISC CISC merged commit aa0ef5c into master Jun 21, 2025
1 check passed
@CISC CISC deleted the cisc/fix-qwen3-embedding-eos branch June 21, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python python script changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: fix handling of Qwen3-Embedding-0.6B input to add EOS token
2 participants