Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found out that python hashlib that is already included in this repo has sha256 in addition to the sha1 we are already using for sha1 and uuid hash.
We have already implemented this in the C version of llama-gguf-hash so might as well include it in the python version.
Cross Checking
gguf_hash.py
with the C implementationllama-gguf-hash
(side thought: Would it be worth having
general.sha256
to have self validating gguf files... sounds interesting... but likely only makes sense in the context of cryptographic signing of tensor data... which will require more thought on standardizing the authenticity and verification of tensor weights as not being tampered with... and llama.cpp is a bit too new to do something like that in my opinion)