-
Notifications
You must be signed in to change notification settings - Fork 61.8k
Article doesn't do a good job of explaining Only allow secure two-factor methods
#38087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
One of these pages should also clarify (if true, because I am not sure) that enabling 'secure' actually disables users that have SMS/text 2FA configured at all. If it is not true, it should also clarify what users would get disabled. I was surprised to find myself in the insecure list while I only ever use TOTP or Yubikey. |
For perspective, here's what that screen shows:
The link at the bottom of this text should have been to Requiring secure methods of two-factor authentication in your organization |
Only allow secure two-factor methods
Only allow secure two-factor methods
A user in my org reported:
|
This comment has been minimized.
This comment has been minimized.
@jsoref Thanks for opening this issue! This looks like it's a victim of new changes without time for documentation to catch up, so let me see if there are already plans to update this or if it somehow got overlooked. |
While this is being considered for reworking, please consider also trying to communicate which sets of two-factor methods must be enabled before a user can delete their SMS method. I was surprised that two Yubikeys weren't sufficient, adding the Mobile app wasn't sufficient, and I had to configure a TOTP (or HOTP?) source. Taking two false turns before stumbling on the right answer wasn't great fun. Thanks |
@setharnold I'll add it to the list of things causing friction in this article. Thanks. |
Code of Conduct
What article on docs.github.com is affected?
https://docs.github.com/en/authentication/securing-your-account-with-two-factor-authentication-2fa/about-two-factor-authentication
What part(s) of the article would you like to see updated?
The text that mentions SMS should be relegated to something approximating a footnote:
Add a section that talks about:
/organizations/:org/settings/security
Additional information
The setting for
Only allow secure two-factor methods
is pretty new and the way it behaves is incredibly surprising. I've spoken to a couple of people and so far everyone has been surprised at the process to enable it and the docs are just this page which doesn't help.Ideally that view would warn "hey, you observer, your account has SMS enabled, you should go to https://github.com/settings/security and remove it", and ideally it would give an admin a hint about how many accounts would be impacted by this setting (there's a difference between
0
,1
-5
, and1000
)The text was updated successfully, but these errors were encountered: