-
Notifications
You must be signed in to change notification settings - Fork 18.3k
Open
Labels
ToolsThis label describes issues relating to any tools in the x/tools repository.This label describes issues relating to any tools in the x/tools repository.goplsIssues related to the Go language server, gopls.Issues related to the Go language server, gopls.gopls/imports
Milestone
Description
Reported from @seankhliao in slack: gopls reported internal/singleflight
(from std) as a completion candidate, while not working in std.
Though related to unimported completion of standard library candidates, I think this is distinct from #63767. Specifically, I am suspicious of the 'fast path' unimported completion which looks at packages already in the import graph:
https://cs.opensource.google/go/x/tools/+/master:gopls/internal/lsp/source/completion/completion.go;l=1695;drc=7f23bc81dc216f83d56b5256abc053109bf5c58b
@seankhliao can you go list -deps ./... | grep singleflight
to confirm that this package is in your import graph?
Metadata
Metadata
Assignees
Labels
ToolsThis label describes issues relating to any tools in the x/tools repository.This label describes issues relating to any tools in the x/tools repository.goplsIssues related to the Go language server, gopls.Issues related to the Go language server, gopls.gopls/imports