Skip to content

cmd/go: add support for wildcards in 'go list -m' #45719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

cmd/go: add support for wildcards in 'go list -m' #45719

wants to merge 3 commits into from
+71 −29

Conversation

jamdagni86
Copy link
Contributor

go list -m supports wildcards. however, when combined with version queries, it errors out. the commit makes it work when both are provided.

Fixes #45485

@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Apr 23, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: 4374a74) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/312950 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 1:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/312950.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Raghavendra Nagaraj:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/312950.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Raghavendra Nagaraj:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/312950.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/312950.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 6824608) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/312950 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Raghavendra Nagaraj:

Patch Set 2:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/312950.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 2: Run-TryBot+1 Code-Review+1 Trust+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/312950.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/312950.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 2: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/312950.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Raghavendra Nagaraj:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/312950.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Michael Matloob:

Patch Set 2: Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/312950.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/312950.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Raghavendra Nagaraj:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/312950.
After addressing review feedback, remember to publish your drafts!

jamdagni86 added 3 commits May 12, 2021 10:54
@jamdagni86
cmd/go: adding support for wildcards in 'go list -m'
eac53bc 
go list -m supports wildcards. however, when combined with version queries, it errors out. the commit makes it work when both are provided.

Fixes golang#45485
@jamdagni86
cmd/go: adding support for wildcards in 'go list -m' incorporating co…
0c8e617 
…de review comments, bug fixes and adding more test cases
@jamdagni86
cmd/go: adding support for wildcards in 'go list -m' incorporating co…
421ee96 
…de review comments
@gopherbot
Copy link
Contributor

This PR (HEAD: 421ee96) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/312950 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Raghavendra Nagaraj:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/312950.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 1:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/312950.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Raghavendra Nagaraj:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/312950.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Raghavendra Nagaraj:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/312950.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/312950.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Raghavendra Nagaraj:

Patch Set 2:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/312950.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 2: Run-TryBot+1 Code-Review+1 Trust+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/312950.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/312950.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 2: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/312950.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Raghavendra Nagaraj:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/312950.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Michael Matloob:

Patch Set 2: Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/312950.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/312950.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Raghavendra Nagaraj:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/312950.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Raghavendra Nagaraj:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/312950.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cmd/go: 'go list -m' wildcards don't work with version queries
2 participants
@jamdagni86 @gopherbot