-
Notifications
You must be signed in to change notification settings - Fork 18.3k
fmt: clear width and precision in fmt.init #60224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Width and precision may be abnormally large after format missing or wrong args.
This PR (HEAD: 83aa3b1) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/495156 to see it. Tip: You can toggle comments from me using the |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/495156. |
Message from Ian Lance Taylor: Patch Set 1: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/495156. |
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/495156. |
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/495156. |
Message from Gopher Robot: Patch Set 1: TryBot-Result-1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/495156. |
Message from Ian Lance Taylor: Patch Set 2: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/495156. |
Message from Gopher Robot: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/495156. |
Message from Gopher Robot: Patch Set 2: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/495156. |
Message from Ian Lance Taylor: Patch Set 2: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/495156. |
Message from Rob Pike: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/495156. |
Message from Rob Pike: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/495156. |
width and precision may be abnormally large when missing args.
it case unnecessary large mem alloc, as follows:
func test() {
var m runtime.MemStats
runtime.ReadMemStats(&m)
fmt.Printf("1. mem init: %+v\n", m.TotalAlloc)
fmt.Printf("2. fault print: %.9000000f\n", "aaa")
fmt.Printf("3. normal print %02d%02d\n", 1, 1)
runtime.ReadMemStats(&m)
fmt.Printf("4. mem after: %+v\n", m.TotalAlloc)
}
// 1. mem init: 105856
// 2. fault print: %!f(string=aaa)
// 3. normal print 0101
// 4. mem after: 18123680