Skip to content

refactor(samples): query pagination #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2020
Merged

refactor(samples): query pagination #1008

merged 1 commit into from
Dec 9, 2020

Conversation

pmakani
Copy link
Contributor

@pmakani pmakani commented Dec 9, 2020

Fixes #992

@pmakani pmakani requested review from stephaniewang526 and a team December 9, 2020 09:27
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 9, 2020
@product-auto-label product-auto-label bot added api: bigquery Issues related to the googleapis/java-bigquery API. samples Issues that are directly related to samples. labels Dec 9, 2020
@codecov
Copy link

codecov bot commented Dec 9, 2020 •
edited
Loading

Codecov Report

Merging #1008 (56caf06) into master (9c97f4a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1008   +/-   ##
=========================================
  Coverage     80.18%   80.18%           
  Complexity     1268     1268           
=========================================
  Files            79       79           
  Lines          6576     6576           
  Branches        760      760           
=========================================
  Hits           5273     5273           
  Misses          910      910           
  Partials        393      393

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c97f4a...56caf06. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit 7f2e5ca into googleapis:master Dec 9, 2020
@pmakani pmakani deleted the bigquery-992 branch December 11, 2020 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eaball35 eaball35 eaball35 approved these changes

+1 more reviewer

@stephaniewang526 stephaniewang526 stephaniewang526 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@stephaniewang526 stephaniewang526

@eaball35 eaball35

Labels
api: bigquery Issues related to the googleapis/java-bigquery API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs(samples): improve queryPagination sample
3 participants
@pmakani @stephaniewang526 @eaball35