Skip to content

Commit 7354e19

Browse files
docs: Update spec for WriteObjectRequest.object_size to clarify that it applies to both one-shot and resumable writes (#1976)
* docs: Update spec for WriteObjectRequest.object_size to clarify that it applies to both one-shot and resumable writes docs: update routing annotations for CancelResumableWriteRequest and QueryWriteStatusRequest docs: add pointer to public documentation URL PiperOrigin-RevId: 523412992 Source-Link: googleapis/googleapis@11ddd42 Source-Link: https://github.com/googleapis/googleapis-gen/commit/dfb931e19bca32bcb1aa235745599b0fa5a5a222 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZGZiOTMxZTE5YmNhMzJiY2IxYWEyMzU3NDU1OTliMGZhNWE1YTIyMiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
1 parent bbb8990 commit 7354e19

File tree

5 files changed

+6
-16
lines changed

5 files changed

+6
-16
lines changed

gapic-google-cloud-storage-v2/src/main/java/com/google/storage/v2/stub/GrpcStorageStub.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -472,7 +472,7 @@ public class GrpcStorageStub extends StorageStub {
472472
private static final PathTemplate DELETE_OBJECT_0_PATH_TEMPLATE =
473473
PathTemplate.create("{bucket=**}");
474474
private static final PathTemplate CANCEL_RESUMABLE_WRITE_0_PATH_TEMPLATE =
475-
PathTemplate.create("{bucket=projects/*/buckets/*}/**");
475+
PathTemplate.create("{bucket=projects/*/buckets/*}:**");
476476
private static final PathTemplate GET_OBJECT_0_PATH_TEMPLATE = PathTemplate.create("{bucket=**}");
477477
private static final PathTemplate READ_OBJECT_0_PATH_TEMPLATE =
478478
PathTemplate.create("{bucket=**}");
@@ -487,7 +487,7 @@ public class GrpcStorageStub extends StorageStub {
487487
private static final PathTemplate START_RESUMABLE_WRITE_0_PATH_TEMPLATE =
488488
PathTemplate.create("{bucket=**}");
489489
private static final PathTemplate QUERY_WRITE_STATUS_0_PATH_TEMPLATE =
490-
PathTemplate.create("{bucket=projects/*/buckets/*}/**");
490+
PathTemplate.create("{bucket=projects/*/buckets/*}:**");
491491
private static final PathTemplate GET_SERVICE_ACCOUNT_0_PATH_TEMPLATE =
492492
PathTemplate.create("{project=**}");
493493
private static final PathTemplate CREATE_HMAC_KEY_0_PATH_TEMPLATE =

proto-google-cloud-storage-v2/src/main/java/com/google/storage/v2/StorageProto.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -811,7 +811,7 @@ public static com.google.protobuf.Descriptors.FileDescriptor getDescriptor() {
811811
+ "ncelResumableWriteRequest\032/.google.stora"
812812
+ "ge.v2.CancelResumableWriteResponse\"A\212\323\344\223"
813813
+ "\002/\022-\n\tupload_id\022 {bucket=projects/*/buck"
814-
+ "ets/*}/**\332A\tupload_id\022\225\001\n\tGetObject\022#.go"
814+
+ "ets/*}:**\332A\tupload_id\022\225\001\n\tGetObject\022#.go"
815815
+ "ogle.storage.v2.GetObjectRequest\032\031.googl"
816816
+ "e.storage.v2.Object\"H\212\323\344\223\002\027\022\025\n\006bucket\022\013{"
817817
+ "bucket=**}\332A\rbucket,object\332A\030bucket,obje"
@@ -841,7 +841,7 @@ public static com.google.protobuf.Descriptors.FileDescriptor getDescriptor() {
841841
+ "storage.v2.QueryWriteStatusRequest\032+.goo"
842842
+ "gle.storage.v2.QueryWriteStatusResponse\""
843843
+ "A\212\323\344\223\002/\022-\n\tupload_id\022 {bucket=projects/*"
844-
+ "/buckets/*}/**\332A\tupload_id\022\200\001\n\021GetServic"
844+
+ "/buckets/*}:**\332A\tupload_id\022\200\001\n\021GetServic"
845845
+ "eAccount\022+.google.storage.v2.GetServiceA"
846846
+ "ccountRequest\032!.google.storage.v2.Servic"
847847
+ "eAccount\"\033\212\323\344\223\002\013\022\t\n\007project\332A\007project\022\225\001"

proto-google-cloud-storage-v2/src/main/java/com/google/storage/v2/WriteObjectSpec.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -327,7 +327,6 @@ public long getIfMetagenerationNotMatch() {
327327
* This situation is considered a client error, and if such an error occurs
328328
* you must start the upload over from scratch, this time sending the correct
329329
* number of bytes.
330-
* The `object_size` value is ignored for one-shot (non-resumable) writes.
331330
* </pre>
332331
*
333332
* <code>optional int64 object_size = 8;</code>
@@ -348,7 +347,6 @@ public boolean hasObjectSize() {
348347
* This situation is considered a client error, and if such an error occurs
349348
* you must start the upload over from scratch, this time sending the correct
350349
* number of bytes.
351-
* The `object_size` value is ignored for one-shot (non-resumable) writes.
352350
* </pre>
353351
*
354352
* <code>optional int64 object_size = 8;</code>
@@ -1487,7 +1485,6 @@ public Builder clearIfMetagenerationNotMatch() {
14871485
* This situation is considered a client error, and if such an error occurs
14881486
* you must start the upload over from scratch, this time sending the correct
14891487
* number of bytes.
1490-
* The `object_size` value is ignored for one-shot (non-resumable) writes.
14911488
* </pre>
14921489
*
14931490
* <code>optional int64 object_size = 8;</code>
@@ -1508,7 +1505,6 @@ public boolean hasObjectSize() {
15081505
* This situation is considered a client error, and if such an error occurs
15091506
* you must start the upload over from scratch, this time sending the correct
15101507
* number of bytes.
1511-
* The `object_size` value is ignored for one-shot (non-resumable) writes.
15121508
* </pre>
15131509
*
15141510
* <code>optional int64 object_size = 8;</code>
@@ -1529,7 +1525,6 @@ public long getObjectSize() {
15291525
* This situation is considered a client error, and if such an error occurs
15301526
* you must start the upload over from scratch, this time sending the correct
15311527
* number of bytes.
1532-
* The `object_size` value is ignored for one-shot (non-resumable) writes.
15331528
* </pre>
15341529
*
15351530
* <code>optional int64 object_size = 8;</code>
@@ -1554,7 +1549,6 @@ public Builder setObjectSize(long value) {
15541549
* This situation is considered a client error, and if such an error occurs
15551550
* you must start the upload over from scratch, this time sending the correct
15561551
* number of bytes.
1557-
* The `object_size` value is ignored for one-shot (non-resumable) writes.
15581552
* </pre>
15591553
*
15601554
* <code>optional int64 object_size = 8;</code>

proto-google-cloud-storage-v2/src/main/java/com/google/storage/v2/WriteObjectSpecOrBuilder.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,6 @@ public interface WriteObjectSpecOrBuilder
211211
* This situation is considered a client error, and if such an error occurs
212212
* you must start the upload over from scratch, this time sending the correct
213213
* number of bytes.
214-
* The `object_size` value is ignored for one-shot (non-resumable) writes.
215214
* </pre>
216215
*
217216
* <code>optional int64 object_size = 8;</code>
@@ -229,7 +228,6 @@ public interface WriteObjectSpecOrBuilder
229228
* This situation is considered a client error, and if such an error occurs
230229
* you must start the upload over from scratch, this time sending the correct
231230
* number of bytes.
232-
* The `object_size` value is ignored for one-shot (non-resumable) writes.
233231
* </pre>
234232
*
235233
* <code>optional int64 object_size = 8;</code>

proto-google-cloud-storage-v2/src/main/proto/google/storage/v2/storage.proto

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ service Storage {
252252
option (google.api.routing) = {
253253
routing_parameters {
254254
field: "upload_id"
255-
path_template: "{bucket=projects/*/buckets/*}/**"
255+
path_template: "{bucket=projects/*/buckets/*}:**"
256256
}
257257
};
258258
option (google.api.method_signature) = "upload_id";
@@ -391,7 +391,7 @@ service Storage {
391391
option (google.api.routing) = {
392392
routing_parameters {
393393
field: "upload_id"
394-
path_template: "{bucket=projects/*/buckets/*}/**"
394+
path_template: "{bucket=projects/*/buckets/*}:**"
395395
}
396396
};
397397
option (google.api.method_signature) = "upload_id";
@@ -963,8 +963,6 @@ message WriteObjectSpec {
963963
// This situation is considered a client error, and if such an error occurs
964964
// you must start the upload over from scratch, this time sending the correct
965965
// number of bytes.
966-
//
967-
// The `object_size` value is ignored for one-shot (non-resumable) writes.
968966
optional int64 object_size = 8;
969967
}
970968

0 commit comments

Comments
 (0)