-
Notifications
You must be signed in to change notification settings - Fork 381
fix: Remove packaging package upper bound #2005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hi @r-richmond, could you add "fix: ..." in the beginning of the title so it follows conventional commits and also make sure to sign Google's CLA. Thanks for opening this PR! |
01c521c
to
f7ce84a
Compare
@nayaknishant done |
Hi @r-richmond, seems to still be a CLA issue |
@nayaknishant got it to go through |
@nayaknishant anything else needed here? looks like all the tests passed. |
Thanks @r-richmond! |
@nayaknishant should I rebase the branch on main or are we waiting for something else? |
Hi @r-richmond, we're currently making some internal changes to the repository. We'll return to this issue soon. |
Hello! We'd be interested in seeing this change go through too, as this currently conflicts with the latest version of the |
I rebased onto main in the hopes that @nayaknishant will be able to merge soon |
-- b3a454c by r-richmond <[email protected]>: fix: Remove packaging package upper bound COPYBARA_INTEGRATE_REVIEW=#2005 from r-richmond:patch-1 e6ba5c9 PiperOrigin-RevId: 524048487
Hi @r-richmond, thanks for your patience! Your PR has been merged in here: 73011c0. |
Huzza thanks @nayaknishant Any idea when a release will go out that includes this change? |
We plan on having a patch release next week 👍 |
Any update on when this patch is scheduled to be released? |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Note: do not merge your PR from GitHub. Adding the "ready to pull" label is the final step in the review process.
After approvals, the changes in your PR will be committed to the
main
branch and this PR will be closed.Fixes #2004 🦕