Skip to content

fix: Remove packaging package upper bound #2005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from

Conversation

r-richmond
Copy link
Contributor

@r-richmond r-richmond commented Mar 4, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Get the necessary approvals
  • Once the last commit on the PR has been approved, add the "ready to pull" label to the Pull Request

Note: do not merge your PR from GitHub. Adding the "ready to pull" label is the final step in the review process.
After approvals, the changes in your PR will be committed to the main branch and this PR will be closed.

Fixes #2004 🦕

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Mar 4, 2023
@google-cla
Copy link

google-cla bot commented Mar 4, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the api: vertex-ai Issues related to the googleapis/python-aiplatform API. label Mar 4, 2023
@nayaknishant
Copy link
Contributor

nayaknishant commented Mar 9, 2023

Hi @r-richmond, could you add "fix: ..." in the beginning of the title so it follows conventional commits and also make sure to sign Google's CLA. Thanks for opening this PR!

@r-richmond r-richmond force-pushed the patch-1 branch 2 times, most recently from 01c521c to f7ce84a Compare March 9, 2023 23:20
@r-richmond
Copy link
Contributor Author

@nayaknishant done

@nayaknishant
Copy link
Contributor

Hi @r-richmond, seems to still be a CLA issue

@r-richmond
Copy link
Contributor Author

@nayaknishant got it to go through

@nayaknishant nayaknishant added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 21, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 21, 2023
@r-richmond
Copy link
Contributor Author

r-richmond commented Mar 21, 2023

@nayaknishant anything else needed here? looks like all the tests passed.

@nayaknishant
Copy link
Contributor

Thanks @r-richmond!

@nayaknishant nayaknishant added ready to pull Ready to be merged into the codebase. and removed ready to pull Ready to be merged into the codebase. labels Mar 21, 2023
@nayaknishant nayaknishant self-requested a review March 21, 2023 23:25
@nayaknishant nayaknishant added the ready to pull Ready to be merged into the codebase. label Mar 21, 2023
@r-richmond
Copy link
Contributor Author

@nayaknishant should I rebase the branch on main or are we waiting for something else?

@nayaknishant
Copy link
Contributor

Hi @r-richmond, we're currently making some internal changes to the repository. We'll return to this issue soon.

@proteusvacuum
Copy link

Hello! We'd be interested in seeing this change go through too, as this currently conflicts with the latest version of the black package. Thanks!

@r-richmond
Copy link
Contributor Author

I rebased onto main in the hopes that @nayaknishant will be able to merge soon

@holtskinner holtskinner added the automerge Merge the pull request once unit tests and other checks pass. label Apr 10, 2023
@nayaknishant nayaknishant added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 12, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 12, 2023
@nayaknishant nayaknishant added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 12, 2023
@nayaknishant nayaknishant self-requested a review April 12, 2023 17:21
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 12, 2023
@nayaknishant nayaknishant added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 12, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 12, 2023
@nayaknishant nayaknishant added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 13, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 13, 2023
@nayaknishant nayaknishant self-requested a review April 13, 2023 01:03
@nayaknishant nayaknishant added ready to pull Ready to be merged into the codebase. and removed ready to pull Ready to be merged into the codebase. labels Apr 13, 2023
@nayaknishant nayaknishant added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed ready to pull Ready to be merged into the codebase. labels Apr 13, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 13, 2023
copybara-service bot pushed a commit that referenced this pull request Apr 13, 2023
--
b3a454c by r-richmond <[email protected]>:

fix: Remove packaging package upper bound
COPYBARA_INTEGRATE_REVIEW=#2005 from r-richmond:patch-1 e6ba5c9
PiperOrigin-RevId: 524048487
@nayaknishant
Copy link
Contributor

Hi @r-richmond, thanks for your patience! Your PR has been merged in here: 73011c0.

@r-richmond
Copy link
Contributor Author

Huzza thanks @nayaknishant

Any idea when a release will go out that includes this change?

@r-richmond r-richmond deleted the patch-1 branch April 13, 2023 18:57
@nayaknishant
Copy link
Contributor

We plan on having a patch release next week 👍

@ajrheaume
Copy link

Any update on when this patch is scheduled to be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: vertex-ai Issues related to the googleapis/python-aiplatform API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove cautionary pin of packaging package
6 participants