Skip to content

bugfix: fix prediction service and unit tests #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 25, 2020
Merged

bugfix: fix prediction service and unit tests #8

merged 2 commits into from
Sep 25, 2020

Conversation

dizcology
Copy link
Contributor

@dizcology dizcology requested a review from a team as a code owner September 25, 2020 05:16
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 25, 2020
busunkim96
busunkim96 approved these changes Sep 25, 2020
View reviewed changes
google/cloud/aiplatform_v1beta1/services/prediction_service/client.py
@@ -328,7 +328,7 @@ def explain(
if endpoint is not None:
request.endpoint = endpoint
if instances is not None:
request.instances = instances
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Synth will try to revert changes like this in future Autosynth PRs. You can add this entire file to the exclude list, or a write a regex replacement in synth.py.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had this in synth.py but failed to update the relevant line to v1beta1, it has been fixed: https://github.com/googleapis/python-aiplatform/pull/8/files#diff-3620890cb174a7f98c0722895e37bb79R72

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can also reprioritize the issues that cause the need for synth hacks. The repeated field one should be trivial.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, my bad, it looks like that issue has actually been fixed in a more current generator release.

@dizcology dizcology merged commit 3814e7e into googleapis:master Sep 25, 2020
sasha-gitg added a commit that referenced this pull request Nov 9, 2020
@sirtorry @sasha-gitg
feat: adds endpoint class and model deploy/undeploy (#35)
e916640 
* recs

* create endpoint

* deploy model

* undeploy model

* predict placeholders

* use base properties

* address feedback

* address feedback

* use full name

* address comments

* feat: Add Custom Training by Python Script (#6)

* chore: fix LRO tests and formatting

* add tests

* fix typo

* more typos

* address feedback

* feat: Address comments and change args to accept list of args to support positional args and flags.

* feat: rename is_failed to has_failed

* refactor: remove unused Dict type

* Work on predict (#7)

* fix tests

* fix tests

* fix tests

* checkpoint

* Endpoint (#8)

* recs

* create endpoint

* deploy model

* undeploy model

* predict placeholders

* use base properties

* address feedback

* address feedback

* use full name

* address comments

* add tests

* fix typo

* more typos

* address feedback

* fix tests

* fix tests

* fix tests

Co-authored-by: sirtorry <[email protected]>
Co-authored-by: Torry Yang <[email protected]>

* address feedback

* add tests

* appease linters

* fix test

* fix test

* add self to test params

* tests

* tests

* tests

* fix tests

* more bug crushing

* undo 'fix'

* test: fix endpoint test

* chore: change explain ticket ref

* test: fix endpoint tests

Co-authored-by: sasha-gitg <[email protected]>
Co-authored-by: Sasha Sobran <[email protected]>
dizcology pushed a commit to dizcology/python-aiplatform that referenced this pull request Nov 30, 2020
@sirtorry @sasha-gitg @dizcology
feat: adds endpoint class and model deploy/undeploy (googleapis#35)
05e5d6e 
* recs

* create endpoint

* deploy model

* undeploy model

* predict placeholders

* use base properties

* address feedback

* address feedback

* use full name

* address comments

* feat: Add Custom Training by Python Script (googleapis#6)

* chore: fix LRO tests and formatting

* add tests

* fix typo

* more typos

* address feedback

* feat: Address comments and change args to accept list of args to support positional args and flags.

* feat: rename is_failed to has_failed

* refactor: remove unused Dict type

* Work on predict (googleapis#7)

* fix tests

* fix tests

* fix tests

* checkpoint

* Endpoint (googleapis#8)

* recs

* create endpoint

* deploy model

* undeploy model

* predict placeholders

* use base properties

* address feedback

* address feedback

* use full name

* address comments

* add tests

* fix typo

* more typos

* address feedback

* fix tests

* fix tests

* fix tests

Co-authored-by: sirtorry <[email protected]>
Co-authored-by: Torry Yang <[email protected]>

* address feedback

* add tests

* appease linters

* fix test

* fix test

* add self to test params

* tests

* tests

* tests

* fix tests

* more bug crushing

* undo 'fix'

* test: fix endpoint test

* chore: change explain ticket ref

* test: fix endpoint tests

Co-authored-by: sasha-gitg <[email protected]>
Co-authored-by: Sasha Sobran <[email protected]>
dizcology pushed a commit to dizcology/python-aiplatform that referenced this pull request Nov 30, 2020
@sirtorry @sasha-gitg @dizcology
feat: adds endpoint class and model deploy/undeploy (googleapis#35)
6d88fd8 
* recs

* create endpoint

* deploy model

* undeploy model

* predict placeholders

* use base properties

* address feedback

* address feedback

* use full name

* address comments

* feat: Add Custom Training by Python Script (googleapis#6)

* chore: fix LRO tests and formatting

* add tests

* fix typo

* more typos

* address feedback

* feat: Address comments and change args to accept list of args to support positional args and flags.

* feat: rename is_failed to has_failed

* refactor: remove unused Dict type

* Work on predict (googleapis#7)

* fix tests

* fix tests

* fix tests

* checkpoint

* Endpoint (googleapis#8)

* recs

* create endpoint

* deploy model

* undeploy model

* predict placeholders

* use base properties

* address feedback

* address feedback

* use full name

* address comments

* add tests

* fix typo

* more typos

* address feedback

* fix tests

* fix tests

* fix tests

Co-authored-by: sirtorry <[email protected]>
Co-authored-by: Torry Yang <[email protected]>

* address feedback

* add tests

* appease linters

* fix test

* fix test

* add self to test params

* tests

* tests

* tests

* fix tests

* more bug crushing

* undo 'fix'

* test: fix endpoint test

* chore: change explain ticket ref

* test: fix endpoint tests

Co-authored-by: sasha-gitg <[email protected]>
Co-authored-by: Sasha Sobran <[email protected]>
dizcology pushed a commit to dizcology/python-aiplatform that referenced this pull request Nov 30, 2020
@sirtorry @sasha-gitg @dizcology
feat: adds endpoint class and model deploy/undeploy (googleapis#35)
a70bd0e 
* recs

* create endpoint

* deploy model

* undeploy model

* predict placeholders

* use base properties

* address feedback

* address feedback

* use full name

* address comments

* feat: Add Custom Training by Python Script (googleapis#6)

* chore: fix LRO tests and formatting

* add tests

* fix typo

* more typos

* address feedback

* feat: Address comments and change args to accept list of args to support positional args and flags.

* feat: rename is_failed to has_failed

* refactor: remove unused Dict type

* Work on predict (googleapis#7)

* fix tests

* fix tests

* fix tests

* checkpoint

* Endpoint (googleapis#8)

* recs

* create endpoint

* deploy model

* undeploy model

* predict placeholders

* use base properties

* address feedback

* address feedback

* use full name

* address comments

* add tests

* fix typo

* more typos

* address feedback

* fix tests

* fix tests

* fix tests

Co-authored-by: sirtorry <[email protected]>
Co-authored-by: Torry Yang <[email protected]>

* address feedback

* add tests

* appease linters

* fix test

* fix test

* add self to test params

* tests

* tests

* tests

* fix tests

* more bug crushing

* undo 'fix'

* test: fix endpoint test

* chore: change explain ticket ref

* test: fix endpoint tests

Co-authored-by: sasha-gitg <[email protected]>
Co-authored-by: Sasha Sobran <[email protected]>
dizcology pushed a commit to dizcology/python-aiplatform that referenced this pull request Nov 30, 2020
@sirtorry @sasha-gitg @dizcology
feat: adds endpoint class and model deploy/undeploy (googleapis#35)
089b60c 
* recs

* create endpoint

* deploy model

* undeploy model

* predict placeholders

* use base properties

* address feedback

* address feedback

* use full name

* address comments

* feat: Add Custom Training by Python Script (googleapis#6)

* chore: fix LRO tests and formatting

* add tests

* fix typo

* more typos

* address feedback

* feat: Address comments and change args to accept list of args to support positional args and flags.

* feat: rename is_failed to has_failed

* refactor: remove unused Dict type

* Work on predict (googleapis#7)

* fix tests

* fix tests

* fix tests

* checkpoint

* Endpoint (googleapis#8)

* recs

* create endpoint

* deploy model

* undeploy model

* predict placeholders

* use base properties

* address feedback

* address feedback

* use full name

* address comments

* add tests

* fix typo

* more typos

* address feedback

* fix tests

* fix tests

* fix tests

Co-authored-by: sirtorry <[email protected]>
Co-authored-by: Torry Yang <[email protected]>

* address feedback

* add tests

* appease linters

* fix test

* fix test

* add self to test params

* tests

* tests

* tests

* fix tests

* more bug crushing

* undo 'fix'

* test: fix endpoint test

* chore: change explain ticket ref

* test: fix endpoint tests

Co-authored-by: sasha-gitg <[email protected]>
Co-authored-by: Sasha Sobran <[email protected]>
dizcology pushed a commit to dizcology/python-aiplatform that referenced this pull request Nov 30, 2020
@sirtorry @sasha-gitg @dizcology
feat: adds endpoint class and model deploy/undeploy (googleapis#35)
78f4746 
* recs

* create endpoint

* deploy model

* undeploy model

* predict placeholders

* use base properties

* address feedback

* address feedback

* use full name

* address comments

* feat: Add Custom Training by Python Script (googleapis#6)

* chore: fix LRO tests and formatting

* add tests

* fix typo

* more typos

* address feedback

* feat: Address comments and change args to accept list of args to support positional args and flags.

* feat: rename is_failed to has_failed

* refactor: remove unused Dict type

* Work on predict (googleapis#7)

* fix tests

* fix tests

* fix tests

* checkpoint

* Endpoint (googleapis#8)

* recs

* create endpoint

* deploy model

* undeploy model

* predict placeholders

* use base properties

* address feedback

* address feedback

* use full name

* address comments

* add tests

* fix typo

* more typos

* address feedback

* fix tests

* fix tests

* fix tests

Co-authored-by: sirtorry <[email protected]>
Co-authored-by: Torry Yang <[email protected]>

* address feedback

* add tests

* appease linters

* fix test

* fix test

* add self to test params

* tests

* tests

* tests

* fix tests

* more bug crushing

* undo 'fix'

* test: fix endpoint test

* chore: change explain ticket ref

* test: fix endpoint tests

Co-authored-by: sasha-gitg <[email protected]>
Co-authored-by: Sasha Sobran <[email protected]>
dizcology pushed a commit to dizcology/python-aiplatform that referenced this pull request Dec 22, 2020
@sirtorry @sasha-gitg @dizcology
feat: adds endpoint class and model deploy/undeploy (googleapis#35)
cdc49fe 
* recs

* create endpoint

* deploy model

* undeploy model

* predict placeholders

* use base properties

* address feedback

* address feedback

* use full name

* address comments

* feat: Add Custom Training by Python Script (googleapis#6)

* chore: fix LRO tests and formatting

* add tests

* fix typo

* more typos

* address feedback

* feat: Address comments and change args to accept list of args to support positional args and flags.

* feat: rename is_failed to has_failed

* refactor: remove unused Dict type

* Work on predict (googleapis#7)

* fix tests

* fix tests

* fix tests

* checkpoint

* Endpoint (googleapis#8)

* recs

* create endpoint

* deploy model

* undeploy model

* predict placeholders

* use base properties

* address feedback

* address feedback

* use full name

* address comments

* add tests

* fix typo

* more typos

* address feedback

* fix tests

* fix tests

* fix tests

Co-authored-by: sirtorry <[email protected]>
Co-authored-by: Torry Yang <[email protected]>

* address feedback

* add tests

* appease linters

* fix test

* fix test

* add self to test params

* tests

* tests

* tests

* fix tests

* more bug crushing

* undo 'fix'

* test: fix endpoint test

* chore: change explain ticket ref

* test: fix endpoint tests

Co-authored-by: sasha-gitg <[email protected]>
Co-authored-by: Sasha Sobran <[email protected]>
jaycee-li added a commit that referenced this pull request Sep 30, 2022
@jaycee-li @dandhlee
feat: Support complex metrics in Vertex Experiments (#1698)
ed0492e 
* Experiments complex metrics (#8)

* feat: new class and API for metrics

* update system test

* update high level log method

* fix system test

* update example

* change from system schema to google schema

* fix: import error

* Update log_classification_metrics_sample.py

* Update samples/model-builder/experiment_tracking/log_classification_metrics_sample.py

Co-authored-by: Dan Lee <[email protected]>

* Update log_classification_metrics_sample_test.py

* Update samples/model-builder/conftest.py

Co-authored-by: Dan Lee <[email protected]>

* fix: unit test

* fix comments

* fix comments and update google.ClassificationMetrics

* fix comments and update ClassificationMetrics class

* fix: ClassificationMetrics doesn't catch params with value=0

* add sample for get_classification_metrics

* fix linting

* add todos

Co-authored-by: Dan Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinnysenthil vinnysenthil Awaiting requested review from vinnysenthil

2 more reviewers

@software-dov software-dov software-dov left review comments

@busunkim96 busunkim96 busunkim96 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dizcology @software-dov @busunkim96