refactor: simplify filter and join nodes #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tswast
reviewed
Jan 17, 2024
bigframes/core/blocks.py
Outdated
| self.expr.column_ids, other.expr.column_ids | ||
| left_mappings = [ | ||
| join_defs.JoinColumnMapping( | ||
| join_defs.JoinSide.LEFT, id, guid.generate_guid() |
There was a problem hiding this comment.
Please use keyword arguments for these JoinColumnMapping constructor arguments. It's difficult for me to check correctness. We might even want to force the use of keyword arguments with the use of * syntax.
There was a problem hiding this comment.
Switched from namedtuple to dataclass and set kw_only=True
There was a problem hiding this comment.
ok, removed kw_only=True as that isn't allowed in old python versions, but still made all actual constructor invocations use kw args
a59aa43 to
0f58fb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕