Skip to content
This repository was archived by the owner on Sep 5, 2023. It is now read-only.

chore: prevent normalization of semver versioning #32

Merged
merged 2 commits into from
Apr 16, 2021

Conversation

dandhlee
Copy link
Contributor

When there is a patch version added to semver versioning, setuptools.setup(version) will normalize the versioning from -patch to .patch which is not correct SEMVER versioning. The added feature with setuptools.sic(version) will prevent this from happening.

@dandhlee dandhlee requested a review from a team as a code owner April 14, 2021 23:32
@product-auto-label product-auto-label bot added the api: notebooks Issues related to the googleapis/python-notebooks API. label Apr 14, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 14, 2021
@dandhlee dandhlee merged commit 0ea1aa9 into master Apr 16, 2021
@dandhlee dandhlee deleted the remove-semver-normalization branch April 16, 2021 21:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: notebooks Issues related to the googleapis/python-notebooks API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants