Skip to content

[Bug] disabling Explore AAR still downloads and modifies AARs #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shefich opened this issue Dec 22, 2022 · 3 comments · Fixed by #593, viliamvolosv/unity-jar-resolver#1, #613 or #616
Closed

Comments

@shefich
Copy link

shefich commented Dec 22, 2022

[REQUIRED] Please fill in the following fields:

  • Unity editor version: 2020.3
  • External Dependency Manager version: 1.2.175
  • Source you installed EDM4U: .unitypackage
  • Features in External Dependency Manager in use: Android Resolver
  • Plugins SDK in use: Admob
  • Platform you are using the Unity editor on: Windows

[REQUIRED] Please describe the issue here:

Disable "Explode AARs" in Android Resolver Settings and then make Force Resolve.
AARs are still downloaded and exploaded to the Plugins/Android folder.

@shefich shefich added new to be triaged type: question labels Dec 22, 2022
@google-oss-bot
Copy link

This issue does not seem to follow the issue template. Make sure you provide all the required information.

@paulinon
Copy link
Collaborator

Hi @shefich,

Thank you for filing this issue. I was able to see this behavior on the editor using the information you provided. The resolver settings mention that AAR explosion will be disabled in exported Gradle builds. Could you try exporting the project and see if there's a difference between enabling and disabling Explode AARs? You may provide other relevant information that would help the investigation.

@paulinon paulinon added needs-info Need information for the developer and removed type: question labels Dec 23, 2022
@shefich
Copy link
Author

shefich commented Dec 23, 2022

Hi @paulinon ,

"The resolver settings mention that AAR explosion will be disabled in exported Gradle builds" - it says that this option will be disabled for exporting the project. I am not exporting the project. How to disable it completely?
The main difference in my projects is in the "Force build". The settings are the same, but one project just make changes in gradle and dependencies files. Other project adds or explodes AARs. Disabling or enabling "Explode AARs" does nothing in project.

@google-oss-bot google-oss-bot added needs-attention Need Googler's attention and removed needs-info Need information for the developer labels Dec 23, 2022
doterax pushed a commit to doterax/unity-jar-resolver that referenced this issue Jan 20, 2023
@chkuang-g chkuang-g added type: bug and removed type: question needs-attention Need Googler's attention labels Feb 13, 2023
@chkuang-g chkuang-g reopened this Apr 15, 2023
chkuang-g added a commit that referenced this issue Apr 27, 2023
- Version 1.2.176 - Apr 27, 2023
* Android Resolver - Added two Android Resolver settings to determine whether
  EDM4U injects custom local Maven repo path as a relative path or full path.
  Fixes #537
* Android Resolver - Inject Maven Repo to `settingTemplate.gradle` from
  Unity `2022.2+`
  Fixes #594
* Android Resolver - Jetifier option is enabled by default now.
* Android Resolver - `Explode Aar` option applies to all cases, whether the
  project will be exported or not.
  Fixes #584
  Fixes #287
chkuang-g added a commit that referenced this issue Apr 27, 2023
- Version 1.2.176 - Apr 27, 2023
* Android Resolver - Added two Android Resolver settings to determine whether
  EDM4U injects custom local Maven repo path as a relative path or full path.
  Fixes #537
* Android Resolver - Inject Maven Repo to `settingTemplate.gradle` from
  Unity `2022.2+`
  Fixes #594
* Android Resolver - Jetifier option is enabled by default now.
* Android Resolver - `Explode Aar` option applies to all cases, whether the
  project will be exported or not.
  Fixes #584
  Fixes #287
@googlesamples googlesamples locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.