Add two Android Resolver settings related to custom local Maven repo path #604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move buttons out of the scroll view so that they are always at the bottom of the setting windows.
Adding two settings in Android Resolver settings to determine whether EDM4U inject custom local Maven repo path as a relative path or full path. Before this settings, EDM4U has internal logic to always use full path when exporting project and relative path when not. Provide the new options so that the developers can choose to make it consistent or use full path to avoid certain Unity bugs.
a-maurice
approved these changes
Mar 22, 2023
chkuang-g
added a commit
that referenced
this pull request
Apr 13, 2023
…path (#604) Adding two settings in Android Resolver settings to determine whether EDM4U inject custom local Maven repo path as a relative path or full path. Before this settings, EDM4U has internal logic to always use full path when exporting project and relative path when not. Provide the new options so that the developers can choose to make it consistent or use full path to avoid certain Unity bugs. Also improve Android Resolver Setting UI by moving buttons out of the scroll view so that they are always at the bottom of the setting windows.
chkuang-g
added a commit
that referenced
this pull request
Apr 14, 2023
…path (#604) Adding two settings in Android Resolver settings to determine whether EDM4U inject custom local Maven repo path as a relative path or full path. Before this settings, EDM4U has internal logic to always use full path when exporting project and relative path when not. Provide the new options so that the developers can choose to make it consistent or use full path to avoid certain Unity bugs. Also improve Android Resolver Setting UI by moving buttons out of the scroll view so that they are always at the bottom of the setting windows.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding two settings in Android Resolver settings to determine whether EDM4U inject custom local Maven repo path as a relative path or full path.
Before these settings, EDM4U has internal logic to always use full path when exporting project and relative path when not. Provide the new options so that the developers can choose to make it consistent or use full path to avoid certain Unity bugs.
Added a new task (Bug# 274671088) to add integration test for this. Currently manually verified with Unity 2022.2 and all integration tests are passed (primarily due to lack of test for full path scenario)