Skip to content

Inject Maven Repo to settingTemplate.gradle from 2022.2+ #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2023

Conversation

chkuang-g
Copy link
Collaborator

  • Add a new feature and settings for Unity 2022.2+ in Android Resolver to enable patching Assets/Plugins/Android/settingsTemplate.gradle for Maven repository specified in Dependencies.xml. If Custom Main Gradle Template is in use, EDM4U will automatically generate on under Assets/Plugins/Android if not presented.
  • Adding two settings in Android Resolver settings to determine whether EDM4U inject custom local Maven repo path as a relative path or full path.
    • Before this settings, EDM4U has internal logic to always use full path when exporting project and relative path when not. Provide the new options so that the developers can choose to make it consistent or use full path to avoid certain Unity bugs.
    • Unfortunately Unity 2022.2.1 to 2022.2.9 does not support template variable like **DIR_UNITYPROJECT** in settingsTemplate.gradle. This is later patched in 2022.2.10. For anyone who is using 2022.2.1 to 2022.2.9, the workaround is always use full path.

Fixes #537
Fixes #594

…path (#604)

Adding two settings in Android Resolver settings to determine whether EDM4U inject custom local Maven repo path as a relative path or full path.

Before this settings, EDM4U has internal logic to always use full path when exporting project and relative path when not. Provide the new options so that the developers can choose to make it consistent or use full path to avoid certain Unity bugs.

Also improve Android Resolver Setting UI by moving buttons out of the scroll view so that they are always at the
bottom of the setting windows.
Add a new feature and settings for Unity 2022.2+ in Android Resolver to
enable patching `Assets/Plugins/Android/settingsTemplate.gradle` for
Maven repository specified in `Dependencies.xml`.
@chkuang-g
Copy link
Collaborator Author

Both changes were reviewed #604 #609

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant