Skip to content

Revert "Do not explode AARs even if gradle project is not enabled" #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2023
Merged

Revert "Do not explode AARs even if gradle project is not enabled" #612

merged 1 commit into from
Apr 15, 2023

Conversation

chkuang-g
Copy link
Collaborator

Reverts #593

This is failing the following tests

Test ResolveForGradleBuildSystemAndExport: FAILED
Test ResolveAddedDependencies: FAILED
Test ResolveRemovedDependencies: FAILED
Test DeleteResolvedLibraries: FAILED

Also, this change is a bit problematic since it means Android Resolver will NEVER explore AAR when export project is enabled.

@chkuang-g chkuang-g merged commit 827d351 into master Apr 15, 2023
@chkuang-g chkuang-g deleted the revert-593-fix/explodeAarsIgnored branch April 15, 2023 01:28
@chkuang-g chkuang-g mentioned this pull request Apr 15, 2023
Merged
@googlesamples googlesamples locked and limited conversation to collaborators May 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chkuang-g