Able to continue tests if one fails #641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new property `CONTINUE_ON_FAIL_FOR_TESTS_ENABLED`. When set to `1`, if one test fails, the build script will continue running the next test and provide a final report when all tests are finished. This currently works for - Unity Integration tests - Python tests This does not work for - Gradle test, ex. `testDownloadArtifacts` - NUnit test
a-maurice
approved these changes
Sep 20, 2023
| @@ -1173,8 +1196,15 @@ Task createUnityTestTask(String taskName, String description, | |||
| setupTestProject.ext.projectDir.name, | |||
| setupTestProject.ext.containerDir, | |||
| additionalArguments, batchMode, | |||
| createTaskClosure) | |||
| createTaskClosure, | |||
| true) | |||
There was a problem hiding this comment.
Should this be continueOnFailForTestsEnabled (or something equivalent)?
There was a problem hiding this comment.
No.
I think it is easier to implement a consistent behavior if we always use EvaluateTestResult to handle whether the test should continue or not. That is
- When
continueOnFailForTestsEnabledis false (or 0), when a test fails,EvaluateTestResult()logs the result and throws an exception to terminate the run, which results in a return code-1 - When
continueOnFailForTestsEnabledis true (or 1), when a test fails,EvaluateTestResult()logs the result. And in the end,reportAllTestsResulttask summarizes the result from every test. If any fails, it throws an exception to end the run, which results in return code-1.
I think this works better no matter one uses ./gradlew test to run every tests or use ./gradlew :testExportUnityPackage to run a specific test. The result reporting will be more consistent.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new property
CONTINUE_ON_FAIL_FOR_TESTS_ENABLED. When set to1, if one test fails, the build script will continue running the next test and provide a final report when all tests are finished.This currently works for
This does not work for
testDownloadArtifacts