Skip to content

Allow base16-bytestring-1.0 #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

phadej
Copy link
Contributor

@phadej phadej commented Sep 17, 2020

Also fix build issue with older bytestring,
which doesn't have IsString instance

Travis build: https://travis-ci.org/github/haskell-hvr/resolv/builds/727960870

Also fix build issue with older bytestring,
which doesn't have IsString instance
@phadej
Copy link
Contributor Author

phadej commented Oct 18, 2020

Ping.

The breaking change in base16-bytestring doesn't affect resolv as it only uses B16.encode.

@mimi1vx
Copy link

mimi1vx commented Dec 17, 2020

@hvr please review/merge , it blocks base16-bytestring in our projects with cabal-install

@mightybyte
Copy link

I made a hackage revision corresponding to the version bound change in this PR.

@andreasabel
Copy link
Member

@phadej wrote:

Also fix build issue with older bytestring, which doesn't have IsString instance.

Is this still relevant? If yes, we will need to rerelease.

@andreasabel
Copy link
Member

Closed in favor of #16 after discussion with @emilypi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants