Skip to content

Remove distro instructions and only leave links #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

hasufell
Copy link
Contributor

@hasufell hasufell commented Apr 3, 2022

@tomjaguarpaw
Copy link
Collaborator

Thanks for this, and thanks for showing the rendered version (I should work out how to get our CI system to do that automatically, at some point ...)

I'm still waiting for more responses to come in, to my call for community comments. Then we'll have a clearer idea how to proceed whilst taking into account the wishes of the community.

I will make a couple of comments on the PR but no need to address them yet.


### Building from source { #from-source }
**DO NOT USE ARCH LINUX PROVIDED GHC PACKAGES. THEY ARE BROKEN.**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be helpful to provide at least some context for statement. For example we could link to an external explanation, such as https://dixonary.co.uk/blog/haskell/cabal-2020.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be helpful to provide at least some context for statement.

Countless users on IRC over the years.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I didn't mean I want you to provide me with justification. Sorry if it came across like that. I meant from the point of view of an Arch user, if they see that comment, they'll likely think "Hmm, that's strange, I wonder what's broken about them ...". We can help short circuit their question by providing some sort of additional information, such as "Arch's insistence on using dynamic linking means that its Haskell packages are very fragile and we suggest that you do not use them.".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Hmm, that's strange, I wonder what's broken about them ..."

My hope is they will ask in their community or their packagers, which will likely spread the word that Haskellers discourage their broken packages. I doubt that will make them think, but hey.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*Note: Most Linux distros don't allow different versions of GHC to be installed in parallel. Sometimes the GHC packages are a bit outdated as well. In either case, consider using [GHCup](#ghcup) instead.*

*Note: haskell-language-server isn't packaged by most distributions. Instead you will have to install it manually, see the [release page](https://github.com/haskell/haskell-language-server/releases), unless you use VSCode, which bootstraps everything automatically. This is optional.*
### Native OS packages { #distro-packages }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would probably be clarifying to provide a short introduction to this section, perhaps something like

If you prefer to install the Haskell toolchain through your operating system's native package management system then you might find the links below useful. These installation methods are not supported by the Haskell community.

@ParetoOptimalDev
Copy link

Rendered/live: https://hasufell-stuff.eu-central-1.linodeobjects.com/www.haskell.org/downloads/index.html

Looking at the rendered version, I feel the Downloads section is a distraction.

We could also rename that simply to "Quickstart" and link to "Learn about the Haskell toolchain" rather than have that on the page.

@hasufell
Copy link
Contributor Author

hasufell commented Apr 3, 2022

I feel the Downloads section is a distraction

This PR is not about other changes to the download page than the distro instructions. Feel free to provide a new PR.

@tomjaguarpaw
Copy link
Collaborator

@hasufell Is it OK if I combine these changes with some others that I'm going to make, based on the responses to the call for comments that I circulated last week?

@hasufell
Copy link
Contributor Author

hasufell commented Apr 9, 2022

@hasufell Is it OK if I combine these changes with some others that I'm going to make, based on the responses to the call for comments that I circulated last week?

What are the changes you are going to make?

@tomjaguarpaw
Copy link
Collaborator

What are the changes you are going to make?

As yet undecided, because I've yet to thoroughly review the feedback, but I will at least include a reference to Nix (@maralorn has agreed to be the owner).

I sense you may be reluctant to let me combine your changes with other changes of my own. If so, that's OK. I can come up with something independently. I just wanted to acknowledge the work you've done towards this.

@hasufell
Copy link
Contributor Author

hasufell commented Apr 9, 2022

What are the changes you are going to make?

As yet undecided, because I've yet to thoroughly review the feedback, but I will at least include a reference to Nix (@maralorn has agreed to be the owner).

I sense you may be reluctant to let me combine your changes with other changes of my own. If so, that's OK. I can come up with something independently. I just wanted to acknowledge the work you've done towards this.

I'm not reluctant at all. But if the end product is significantly different, it might make more sense to copy past pieces of the code instead of including the actual commit.

@tomjaguarpaw
Copy link
Collaborator

OK, thanks.

@tomjaguarpaw
Copy link
Collaborator

@hasufell I made some minor stylistic edits to your PR and made a new PR at #194.

@tomjaguarpaw
Copy link
Collaborator

Thanks for putting this together. Closing, because it has been incorporated into #194.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants