This repository was archived by the owner on Aug 3, 2024. It is now read-only.
Use new function getNameToInstancesIndex instead of tcRnGetInfo #639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is some significant performance improvement in the ghc testsuite. haddock.base: -23.3% haddock.Cabal: -16.7% haddock.compiler: -19.8%
|
Nice! Keep me posted for any performance improvements you measure. And thanks @duog! |
|
@duog Ben just merged your changes to ghc-8.2 branch: I asked Herbert to trigger a new ppa build. This PR will be green soon! |
|
Alex Biehl <[email protected]> writes:
I asked Herbert to trigger a new ppa build. This PR will be green soon!
Let me know when I should bump the submodule.
|
|
@duog travis found two nits! |
|
@duog I took care of that for you! |
|
Thanks again @duog! |
|
Great thanks @alexbiehl |
alexbiehl
added a commit
to alexbiehl/haddock
that referenced
this pull request
Jul 3, 2017
…fo (haskell#639)" This reverts commit d5d8cd1.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is cherry picked from: #636 (some merge conflicts)
There are some significant performance improvements, and it would be good to get this into the ghc-8.2 release.
This depends on the following commits being merged into the ghc-8.2 branch from ghc-master:
f942f65a525dd972cd96e6ae42922b6a3ce4b2d0
271e0f087b6560f445d7e6bd7f6cecec917e1085
So it will not compile in travis until they are merged and make it into the launchpad repository. I have run the test suite and everything is passing.
My branch of ghc-8.2 with those commits is here. It had some merge conflicts.
Tagging @bgamari for visibility.
I will measure the performance on some packages from hackage and report back.