This repository was archived by the owner on Oct 7, 2020. It is now read-only.
Use default config on missing configuration section #1802
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4f794aa to
69c4244
Compare
On serving initialize request, the deserialization of HIE configuration embedded in InitializeParam passed by client will result in an error if during the deserialization process the server cannot find HIE specific configuration key under initializationOptions. This commit changes the initializationOptions deserialization to return the default configuration if configuration key cannot be found under initializationOptions. Here, setting the key with a value of null will also be considered as part of not found condition to accommodate clients that fills missing user options as null.
69c4244 to
76b3c22
Compare
|
@aufarg This project is not actually active any more, so PRs will not be merged. I see you did do something on haskell-language-server too, which is the project superseding this one |
|
@alanz Okay, I'll close the PR then. Thanks for telling me this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use default config on missing configuration section
On serving initialize request, the deserialization of HIE configuration
embedded in InitializeParam passed by client will result in an error if
during the deserialization process the server cannot find HIE specific
configuration key under initializationOptions.
This commit changes the initializationOptions deserialization to return
the default configuration if configuration key cannot be found under
initializationOptions. Here, setting the key with a value of null will
also be considered as part of not found condition to accommodate clients
that fills missing user options as null.