Applying hlint deindents where clause and remove comments

[srid]

Applying a hlint fix messes up the where block in the function. See gif screenshot below.

Your environment

Output of haskell-language-server --probe-tools or haskell-language-server-wrapper --probe-tools:

./haskell-language-server-8.8.4 --probe-tools
haskell-language-server version: 0.6.0.0 (GHC: 8.8.4) (PATH: /home/srid/.local/bin/haskell-language-server-8.8.4) (GIT hash: 61c69fd387281c2222f75f13542eaa2e91cbc1b1)
Tool versions found on the $PATH
cabal:		Not found
stack:		2.5.1
ghc:		Not found

Which lsp-client do you use:

VSCode w/ http://github.com/srid/neuron (Markdown.hs)

Contents of hie.yaml:

cradle:
  cabal:
    - path: "./neuron/src/lib"
      component: "lib:neuron"
    - path: "./neuron/src/app"
      component: "lib:neuron-app-lib"
    - path: "./neuron/src/exe"
      component: "exe:neuron"
    - path: "./neuron/test"
      component: "test:neuron-test"

Steps to reproduce

1. Open Markdown.hs in neuron repo
2. Apply eta reduction hlint for partitionMarkdown

Expected behaviour

only hlint is applied

Actual behaviour

where clause gets deindented. see gif attachment.

Include debug information

Execute in the root of your project the command haskell-language-server --debug . and paste the logs here:

Debug output:

<paste your logs here>

Paste the logs from the lsp-client, e.g. for VS Code

LSP logs:

<paste your logs here>

[srid]

Can't get debug informatoin; the command runs forever.

[srid]

Here's another which deletes the comment in code.

[jneira]

Ugh, that is an ugly one, thanks for reporting it.

Can't get debug informatoin; the command runs forever.

What do you mean? don't you have the log of the haskell extension in the output pane?

[jneira]

I ve reproduced the second one, with the hlint plugin but calling directly hlint /path/to/Module.hs --refactorin the cli too, so it seems to be a bug in apply-refact over a module with this function:

bar :: Maybe Int -> [Int] -> String
bar x y =
  -- this is a comment
  -- this is anothe one 
  if isJust x then "1"
  else if null y then "2"
  else "3"

I am not able to reproduce the first one cause i can't see what hint is being applied. I will try to download neuron and open in vscode. But i suspect it will be a bug in apply-refact too.

[srid]

The first one was Eta reduce, IIRC.

I will try to download neuron and open in vscode

And git checkout aa81be155af28b8af880f615362260203068f1b6 in order to repro (as I've applied hlint on master), or you can undo the below change. Then nix-shell --run "code .".

[jneira]

I've reduced the case to

f  :: String -> String
f x = show x
  where y :: String
        y = "foo"

and it is reproduced by hlint /path/to/Module.hs --refactor too.

[jneira]

Opened issues upstream:

• Apply hint: use guards remove comments above mpickering/apply-refact#93
• Apply hint: eta reduce breaks where block identation mpickering/apply-refact#94