Apply formats again #1824
Merged
Apply formats again #1824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you disable the formatted in certain modules using a pragma? |
|
@pepeiborra Yes, that's a way, but will the list maintenance cost be OK? Maybe it's not that expensive though... |
pepeiborra
approved these changes
May 12, 2021
jneira
approved these changes
May 12, 2021
|
Fixing upstream our actual formatter? :-P |
Ailrun
commented
May 12, 2021
|
|
||
| # Temporarily ignored files | ||
| # Stylish-haskell (and other formatters) does not work well with some CPP usages in these files | ||
| "^ghcide/src/Development/IDE/GHC/Compat.hs$" "^plugins/hls-splice-plugin/src/Ide/Plugin/Splice.hs$" "^ghcide/test/exe/Main.hs$" "ghcide/src/Development/IDE/Core/Rules.hs" "^hls-test-utils/src/Test/Hls/Util.hs$" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm now considering adding CI check for styling, but one big issue is that Haskell formatters (including Stylish-haskell, Ormolu, and Brittany) are not able to parse some specific usage of CPP pragmas.
For example, formatters cannot parse this code:
and give an error. (However, if we move
testto both branches they do not give an error)We have quite a lot modules using pragmas in this way, so adding CI check will cause an unnecessary problems to modifying these modules.
Any idea will be appreciated.