re-enable haddock #3015
Merged
re-enable haddock #3015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We build |
@michaelpj hlint depends on |
|
So it does! Seems fine to me, but @pepeiborra might have thoughts since I know he did stuff in this area recently. |
|
Looks great to me |
pepeiborra
approved these changes
Jul 4, 2022
|
@Mergifyio refresh |
✅ Pull request refreshed |
hololeap
pushed a commit
to hololeap/haskell-language-server
that referenced
this pull request
Aug 26, 2022
* re-enable haddock * fix it for old GHC Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
RaoulHC
added a commit
to RaoulHC/haskell-language-server
that referenced
this pull request
Aug 15, 2023
The ghc-lib flag was removed in haskell#3015, but it's still useful to be able to compile hls-hlint-plugin using the GHC API if you've done so for hlint and ghc-lib-parser-ex, rather than using ghc-lib-parser.
RaoulHC
added a commit
to RaoulHC/haskell-language-server
that referenced
this pull request
Aug 15, 2023
The ghc-lib flag was removed in haskell#3015, but it's still useful to be able to compile hls-hlint-plugin using the GHC API if you've done so for hlint and ghc-lib-parser-ex, rather than using ghc-lib-parser. Cleared out a lot of the HLINT_ON_GHC_LIB gated code which has probably been bitrotting since this flag was removed, there shouldn't be a difference in the API anyway.
RaoulHC
added a commit
to RaoulHC/haskell-language-server
that referenced
this pull request
Aug 15, 2023
The ghc-lib flag was removed in haskell#3015, but it's still useful to be able to compile hls-hlint-plugin using the GHC API if you've done so for hlint and ghc-lib-parser-ex, rather than using ghc-lib-parser. Cleared out a lot of the HLINT_ON_GHC_LIB gated code which has probably been bitrotting since this flag was removed, there shouldn't be a difference in the API anyway.
RaoulHC
added a commit
to RaoulHC/haskell-language-server
that referenced
this pull request
Aug 15, 2023
The ghc-lib flag was removed in haskell#3015, but it's still useful to be able to compile hls-hlint-plugin using the GHC API if you've done so for hlint and ghc-lib-parser-ex, rather than using ghc-lib-parser. Cleared out a lot of the HLINT_ON_GHC_LIB gated code which has probably been bitrotting since this flag was removed, there shouldn't be a difference in the API anyway.
RaoulHC
added a commit
to RaoulHC/haskell-language-server
that referenced
this pull request
Aug 15, 2023
The ghc-lib flag was removed in haskell#3015, but it's still useful to be able to compile hls-hlint-plugin using the GHC API if you've done so for hlint and ghc-lib-parser-ex, rather than using ghc-lib-parser. A lot of the HLINT_ON_GHC_LIB gated code which has probably been bitrotting since this flag was removed has also been removed, ghc-lib-parser API is exactly the same as GHC by design.
RaoulHC
added a commit
to RaoulHC/haskell-language-server
that referenced
this pull request
Aug 15, 2023
The ghc-lib flag was removed in haskell#3015, but it's still useful to be able to compile hls-hlint-plugin using the GHC API if you've done so for hlint and ghc-lib-parser-ex, rather than using ghc-lib-parser. A lot of the HLINT_ON_GHC_LIB gated code which has probably been bitrotting since this flag was removed has also been removed, ghc-lib-parser API is exactly the same as GHC by design.
RaoulHC
added a commit
to RaoulHC/haskell-language-server
that referenced
this pull request
Aug 16, 2023
The ghc-lib flag was removed in haskell#3015, but it's still useful to be able to compile hls-hlint-plugin using the GHC API if you've done so for hlint and ghc-lib-parser-ex, rather than using ghc-lib-parser. A lot of the HLINT_ON_GHC_LIB gated code which has probably been bitrotting since this flag was removed has also been removed, and is probably from when hlint used to work on haskell-src-exts. As ghc-lib-parser has the same API as GHC itself, there's no need for code to be cpp gated.
RaoulHC
added a commit
to RaoulHC/haskell-language-server
that referenced
this pull request
Aug 16, 2023
The ghc-lib flag was removed in haskell#3015, but it's still useful to be able to compile hls-hlint-plugin using the GHC API if you've done so for hlint and ghc-lib-parser-ex, rather than using ghc-lib-parser. A lot of the HLINT_ON_GHC_LIB gated code which has probably been bitrotting since this flag was removed has also been removed, and is probably from when hlint used to work on haskell-src-exts. As ghc-lib-parser has the same API as GHC itself, there's no need for code to be cpp gated.
RaoulHC
added a commit
to RaoulHC/haskell-language-server
that referenced
this pull request
Aug 22, 2023
The ghc-lib flag was removed in haskell#3015, but it's still useful to be able to compile hls-hlint-plugin using the GHC API if you've done so for hlint and ghc-lib-parser-ex, rather than using ghc-lib-parser. A lot of the HLINT_ON_GHC_LIB gated code which has probably been bitrotting so this has been updated to allow hlint to work again directly on the parsed AST.
RaoulHC
added a commit
to RaoulHC/haskell-language-server
that referenced
this pull request
Aug 22, 2023
The ghc-lib flag was removed in haskell#3015, but it's still useful to be able to compile hls-hlint-plugin using the GHC API if you've done so for hlint and ghc-lib-parser-ex, rather than using ghc-lib-parser. A lot of the HLINT_ON_GHC_LIB gated code which has probably been bitrotting since this flag was removed has also been removed, and is probably from when hlint used to work on haskell-src-exts. As ghc-lib-parser has the same API as GHC itself, there's no need for code to be cpp gated.
RaoulHC
added a commit
to RaoulHC/haskell-language-server
that referenced
this pull request
Aug 22, 2023
The ghc-lib flag was removed in haskell#3015, but it's still useful to be able to compile hls-hlint-plugin using the GHC API if you've done so for hlint and ghc-lib-parser-ex, rather than using ghc-lib-parser. A lot of the HLINT_ON_GHC_LIB gated code which has probably been bitrotting since this flag was removed has also been removed, and is probably from when hlint used to work on haskell-src-exts. As ghc-lib-parser has the same API as GHC itself, there's no need for code to be cpp gated.
RaoulHC
added a commit
to RaoulHC/haskell-language-server
that referenced
this pull request
Sep 15, 2023
The ghc-lib flag was removed in haskell#3015, but it's still useful to be able to compile hls-hlint-plugin using the GHC API if you've done so for hlint and ghc-lib-parser-ex, rather than using ghc-lib-parser. A lot of the HLINT_ON_GHC_LIB gated code which has probably been bitrotting since this flag was removed has also been removed, and is probably from when hlint used to work on haskell-src-exts. As ghc-lib-parser has the same API as GHC itself, there's no need for code to be cpp gated.
RaoulHC
added a commit
to RaoulHC/haskell-language-server
that referenced
this pull request
Mar 6, 2024
The ghc-lib flag was removed in haskell#3015, but it's still useful to be able to compile hls-hlint-plugin using the GHC API if you've done so for hlint and ghc-lib-parser-ex, rather than using ghc-lib-parser. A lot of the HLINT_ON_GHC_LIB gated code which has probably been bitrotting since this flag was removed has also been removed, and is probably from when hlint used to work on haskell-src-exts. As ghc-lib-parser has the same API as GHC itself, there's no need for code to be cpp gated.
RaoulHC
added a commit
to RaoulHC/haskell-language-server
that referenced
this pull request
Mar 6, 2024
The ghc-lib flag was removed in haskell#3015, but it's still useful to be able to compile hls-hlint-plugin using the GHC API if you've done so for hlint and ghc-lib-parser-ex, rather than using ghc-lib-parser. A lot of the HLINT_ON_GHC_LIB gated code which has probably been bitrotting since this flag was removed has also been removed, and is probably from when hlint used to work on haskell-src-exts. As ghc-lib-parser has the same API as GHC itself, there's no need for code to be cpp gated.
RaoulHC
added a commit
to RaoulHC/haskell-language-server
that referenced
this pull request
Mar 7, 2024
The ghc-lib flag was removed in haskell#3015, but it's still useful to be able to compile hls-hlint-plugin using the GHC API if you've done so for hlint and ghc-lib-parser-ex, rather than using ghc-lib-parser as it simplifies the build and dependencies.
RaoulHC
added a commit
to RaoulHC/haskell-language-server
that referenced
this pull request
Mar 7, 2024
The ghc-lib flag was removed in haskell#3015, but it's still useful to be able to compile hls-hlint-plugin using the GHC API if you've done so for hlint and ghc-lib-parser-ex, rather than using ghc-lib-parser as it simplifies the build and dependencies.
michaelpj
pushed a commit
that referenced
this pull request
Mar 7, 2024
* Remove bitrotted CPP gated code A lot of the HLINT_ON_GHC_LIB gated code has been bitrotting since this flag was removed. This could be reintroduced if we wanted to directly work on the same parsed AST, but as the hlint ghc plugin showed this may not make much difference: https://www.haskellforall.com/2023/09/ghc-plugin-for-hlint.html * Reintroduce ghc-lib flag for hlint plugin The ghc-lib flag was removed in #3015, but it's still useful to be able to compile hls-hlint-plugin using the GHC API if you've done so for hlint and ghc-lib-parser-ex, rather than using ghc-lib-parser as it simplifies the build and dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we disable
-haddockoption incabal.projectbecauseghc-lib9.2 doesn't build on GHC 8.10.For now, we can remove the dependency on
ghc-libinhls-hlint-plugin, usingghc-lib-parserinstead. (actuallyhlintitself doesn't depend onghc-lib) Meanwhile, I've opened an issue inghc-lib, see: digital-asset/ghc-lib#391