Skip to content

nix: fix nix environment for GHC 9.4 #3133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2022
Merged

nix: fix nix environment for GHC 9.4 #3133

merged 1 commit into from
Sep 16, 2022

Conversation

guibou
Copy link
Collaborator

@guibou guibou commented Sep 1, 2022

This is a work in progress, I'm trying to restore the build with nix.

  • restore nix develop .\#haskell-language-server-941-dev (light environment which provides cabal + ghc)
  • restore the build of all hackages dependencies with nix.

- Bumped nixpkgs, so that's a true GHC 9.4.2 and not 9.4.0, which was
  failing in cabal which because it was detecting <=9.4.1.
- Fixed GHC 9.4 overrides for dependencies
- Use the "default" GHC environment for tooling in the shell. Hence it
  rebuilds less.
- I introduced a flake for cabal-hashes, hence it can be updated
  automatically (with `nix flake update`) and hence we can use
  `callHackage` for any hackage package.
@guibou
Copy link
Collaborator Author

guibou commented Sep 16, 2022

Hello.

Could you review?

It fixs the nix build with all the ghc versions. Does not work on macos for some reasons that I don't understand.

I'd like to see that merged before attempting further cleaning / fixing of the nix solution.

@guibou guibou marked this pull request as ready for review September 16, 2022 10:18
@guibou guibou requested review from kokobd and removed request for michaelpj and berberman September 16, 2022 10:18
Copy link
Collaborator

@kokobd kokobd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@guibou guibou merged commit a66a6c5 into master Sep 16, 2022
@guibou guibou deleted the nix-ghc94 branch September 16, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants